thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62417 from Avogar/dot-product-overflow

Browse Source 
Don't check overflow in  arrayDotProduct in undefined sanitizer
This commit is contained in:
Kruglov Pavel 2024-04-09 10:17:58 +00:00 committed by GitHub
commit 49ba81a5f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Functions/array/arrayDotProduct.cpp
View File

@ -66,13 +66,13 @@ struct DotProduct
};
template <typename Type>
static void accumulate(State<Type> & state, Type x, Type y)
static NO_SANITIZE_UNDEFINED void accumulate(State<Type> & state, Type x, Type y)
{
state.sum += x * y;
}
template <typename Type>
static void combine(State<Type> & state, const State<Type> & other_state)
static NO_SANITIZE_UNDEFINED void combine(State<Type> & state, const State<Type> & other_state)
{
state.sum += other_state.sum;
}

1
tests/queries/0_stateless/03037_dot_product_overflow.reference Normal file
View File

@ -0,0 +1 @@
0

2
tests/queries/0_stateless/03037_dot_product_overflow.sql Normal file
View File

@ -0,0 +1,2 @@
select ignore(dotProduct(materialize([9223372036854775807, 1]), materialize([-3, 1])));