Merge pull request #32960 from bharatnc/ncb/fixes

simplify looping in S2 functions

src/Functions/geoToS2.cpp

@@ -73,7 +73,7 @@ public:
         auto & dst_data = dst->getData();
         dst_data.resize(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const Float64 lon = col_lon->getFloat64(row);
             const Float64 lat = col_lat->getFloat64(row);

src/Functions/s2CapContains.cpp

@@ -91,7 +91,7 @@ public:
         auto & dst_data = dst->getData();
         dst_data.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row=0 ; row < input_rows_count; ++row)
         {
             const auto center = S2CellId(col_center->getUInt(row));
             const Float64 degrees = col_degrees->getFloat64(row);

src/Functions/s2CapUnion.cpp

@@ -95,7 +95,7 @@ public:
         auto & vec_res_radius = col_res_radius->getData();
         vec_res_radius.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const UInt64 first_center = col_center1->getUInt(row);
             const Float64 first_radius = col_radius1->getFloat64(row);

src/Functions/s2CellsIntersect.cpp

@@ -72,7 +72,7 @@ public:
         auto & dst_data = dst->getData();
         dst_data.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const UInt64 id_first = col_id_first->getInt(row);
             const UInt64 id_second = col_id_second->getInt(row);

src/Functions/s2GetNeighbors.cpp

@@ -72,7 +72,7 @@ public:
         dst_offsets.resize(input_rows_count);
         size_t current_offset = 0;
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const UInt64 id = col_id->getUInt(row);
 

src/Functions/s2RectAdd.cpp

@@ -77,7 +77,7 @@ public:
         auto & vec_res_second = col_res_second->getData();
         vec_res_second.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const auto lo = S2CellId(col_lo->getUInt(row));
             const auto hi = S2CellId(col_hi->getUInt(row));

src/Functions/s2RectContains.cpp

@@ -70,7 +70,7 @@ public:
         auto & dst_data = dst->getData();
         dst_data.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const auto lo = S2CellId(col_lo->getUInt(row));
             const auto hi = S2CellId(col_hi->getUInt(row));

src/Functions/s2RectIntersection.cpp

@@ -81,7 +81,7 @@ public:
         auto & vec_res_second = col_res_second->getData();
         vec_res_second.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const auto lo1 = S2CellId(col_lo1->getUInt(row));
             const auto hi1 = S2CellId(col_hi1->getUInt(row));

src/Functions/s2RectUnion.cpp

@@ -79,7 +79,7 @@ public:
         auto & vec_res_second = col_res_second->getData();
         vec_res_second.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const auto lo1 = S2CellId(col_lo1->getUInt(row));
             const auto hi1 = S2CellId(col_hi1->getUInt(row));

src/Functions/s2ToGeo.cpp

@@ -78,7 +78,7 @@ public:
         auto & latitude = col_latitude->getData();
         latitude.reserve(input_rows_count);
 
-        for (const auto row : collections::range(0, input_rows_count))
+        for (size_t row = 0; row < input_rows_count; ++row)
         {
             const auto id = S2CellId(col_id->getUInt(row));