thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-15 19:02:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comment

Browse Source
This commit is contained in:
Robert Schulze 2023-01-04 14:07:21 +00:00
parent 25919ce1f8
commit 4e00a8721a
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Interpreters/Cache/QueryResultCache.h
View File

@ -130,7 +130,7 @@ private:
/// Implementation note: The query result implements a custom caching mechanism and doesn't make use of CacheBase, unlike many other /// Implementation note: The query result implements a custom caching mechanism and doesn't make use of CacheBase, unlike many other
/// internal caches in ClickHouse. The main reason is that we don't need standard CacheBase (S)LRU eviction as the expiry times /// internal caches in ClickHouse. The main reason is that we don't need standard CacheBase (S)LRU eviction as the expiry times
/// associated with cache entries provide a "natural" eviction criterion. As a future TODO, we could make an expiry-based eviction /// associated with cache entries provide a "natural" eviction criterion. As a future TODO, we could make an expiry-based eviction
/// policy and use that with CacheBase. /// policy and use that with CacheBase (e.g. see #23706)
/// TODO To speed up removal of stale entries, we could also add another container sorted on expiry times which maps keys to iterators /// TODO To speed up removal of stale entries, we could also add another container sorted on expiry times which maps keys to iterators
/// into the cache. To insert an entry, add it to the cache + add the iterator to the sorted container. To remove stale entries, do a /// into the cache. To insert an entry, add it to the cache + add the iterator to the sorted container. To remove stale entries, do a
/// binary search on the sorted container and erase all left of the found key. /// binary search on the sorted container and erase all left of the found key.