thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-13 18:02:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

upd comments

Browse Source
This commit is contained in:
Nikita Taranov 2024-02-14 19:53:27 +01:00
parent c2700c4ae6
commit 4e5cfd11d0
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Interpreters/InterpreterInsertQuery.cpp
View File

@ -516,10 +516,10 @@ BlockIO InterpreterInsertQuery::execute()
auto table_id = table->getStorageID(); auto table_id = table->getStorageID();
auto views = DatabaseCatalog::instance().getDependentViews(table_id); auto views = DatabaseCatalog::instance().getDependentViews(table_id);
/// TODO: should we really skip views or not? they have special `parallel_view_processing`, it should be enough? /// It breaks some views-related tests and we have dedicated `parallel_view_processing` for views, so let's just skip them.
pre_streams_size = !table->isView() && views.empty() const bool resize_to_max_insert_threads = !table->isView() && views.empty();
? settings.max_insert_threads pre_streams_size = resize_to_max_insert_threads ? settings.max_insert_threads
: std::min<size_t>(settings.max_insert_threads, pipeline.getNumStreams()); : std::min<size_t>(settings.max_insert_threads, pipeline.getNumStreams());
if (table->supportsParallelInsert()) if (table->supportsParallelInsert())
sink_streams_size = pre_streams_size; sink_streams_size = pre_streams_size;
} }

1
src/Processors/Transforms/buildPushingToViewsChain.cpp
View File

@ -65,7 +65,6 @@ struct ViewsData
StorageID source_storage_id; StorageID source_storage_id;
StorageMetadataPtr source_metadata_snapshot; StorageMetadataPtr source_metadata_snapshot;
StoragePtr source_storage; StoragePtr source_storage;
/// This value is actually only for logs.
size_t max_threads = 1; size_t max_threads = 1;
/// In case of exception happened while inserting into main table, it is pushed to pipeline. /// In case of exception happened while inserting into main table, it is pushed to pipeline.