thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-18 20:32:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #66017 from ClickHouse/backport/24.6/65986

Browse Source 
Backport #65986 to 24.6: Fix race in s3queue
This commit is contained in:
robot-clickhouse-ci-2 2024-07-03 02:55:38 +02:00 committed by GitHub
commit 4e6cf4c75a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Storages/ObjectStorageQueue/ObjectStorageQueueSource.cpp
View File

@ -111,10 +111,12 @@ void ObjectStorageQueueSource::FileIterator::returnForRetry(Source::ObjectInfoPt
if (metadata->useBucketsForProcessing()) if (metadata->useBucketsForProcessing())
{ {
const auto bucket = metadata->getBucketForPath(object_info->relative_path); const auto bucket = metadata->getBucketForPath(object_info->relative_path);
std::lock_guard lock(mutex);
listed_keys_cache[bucket].keys.emplace_front(object_info); listed_keys_cache[bucket].keys.emplace_front(object_info);
} }
else else
{ {
std::lock_guard lock(mutex);
objects_to_retry.push_back(object_info); objects_to_retry.push_back(object_info);
} }
} }