thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ability to start table without metadata in zookeeper

Browse Source
This commit is contained in:
alesapin 2019-03-14 14:49:44 +03:00
parent bdc7614c77
commit 4f43893a35
4 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dbms/src/Storages/StorageReplicatedMergeTree.cpp
View File

@ -277,6 +277,13 @@ StorageReplicatedMergeTree::StorageReplicatedMergeTree(
return;
}
if (attach && !current_zookeeper->exists(zookeeper_path + "/metadata"))
{
LOG_WARNING(log, "No metadata in ZooKeeper: table will be in readonly mode.");
is_readonly = true;
return;
}
if (!attach)
{
if (!data.getDataParts().empty())

0
dbms/tests/integration/test_replication_without_zookeeper/__init__.py Normal file
View File

14
dbms/tests/integration/test_replication_without_zookeeper/configs/remote_servers.xml Normal file
View File

@ -0,0 +1,14 @@
<yandex>
<remote_servers>
<test_cluster>
<shard>
<internal_replication>true</internal_replication>
<replica>
<default_database>shard_0</default_database>
<host>node1</host>
<port>9000</port>
</replica>
</shard>
</test_cluster>
</remote_servers>
</yandex>

51
dbms/tests/integration/test_replication_without_zookeeper/test.py Normal file
View File

@ -0,0 +1,51 @@
import time
import pytest
from helpers.cluster import ClickHouseCluster, CLICKHOUSE_START_COMMAND
from helpers.test_tools import assert_eq_with_retry
cluster = ClickHouseCluster(__file__)
node1 = cluster.add_instance('node1', main_configs=['configs/remote_servers.xml'], with_zookeeper=True, stay_alive=True)
@pytest.fixture(scope="module")
def start_cluster():
try:
cluster.start()
node1.query(
'''
CREATE DATABASE test;
CREATE TABLE test_table(date Date, id UInt32)
ENGINE = ReplicatedMergeTree('/clickhouse/tables/test/replicated', 'node1') ORDER BY id PARTITION BY toYYYYMM(date);
''')
yield cluster
except Exception as ex:
print ex
finally:
cluster.shutdown()
def drop_zk(zk):
zk.delete(path="/clickhouse", recursive=True)
def test_startup_without_zookeeper(start_cluster):
node1.query("INSERT INTO test_table VALUES ('2018-10-01', 1), ('2018-10-02', 2), ('2018-10-03', 3)")
node1.query("SELECT COUNT(*) from test_table") == "3\n"
node1.query("SELECT is_readonly from system.replicas where table='test_table'") == "0\n"
cluster.run_kazoo_commands_with_retries(drop_zk)
time.sleep(5)
node1.query("SELECT COUNT(*) from test_table") == "3\n"
node1.query("SELECT is_readonly from system.replicas where table='test_table'") == "1\n"
node1.exec_in_container(["bash", "-c", "pkill clickhouse"], user='root')
time.sleep(5)
node1.exec_in_container(["bash", "-c", "{} --daemon".format(CLICKHOUSE_START_COMMAND)], user='root')
time.sleep(5)
node1.query("SELECT COUNT(*) from test_table") == "3\n"
node1.query("SELECT is_readonly from system.replicas where table='test_table'") == "1\n"