From 50562da6df7a66b46c32cee9b123b8b1807d59a9 Mon Sep 17 00:00:00 2001
From: Nikolai Kochetov <nik-kochetov@yandex-team.ru>
Date: Thu, 9 Sep 2021 20:08:49 +0300
Subject: [PATCH] More refactoring.

---
 src/Interpreters/InterpreterInsertQuery.cpp   |  2 +-
 .../Transforms/ExpressionTransform.cpp        | 18 +++++++++++++++++-
 .../Transforms/ExpressionTransform.h          | 19 ++++++++++++++++++-
 3 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/src/Interpreters/InterpreterInsertQuery.cpp b/src/Interpreters/InterpreterInsertQuery.cpp
index 530e9a9a8f6..1480e67e1fd 100644
--- a/src/Interpreters/InterpreterInsertQuery.cpp
+++ b/src/Interpreters/InterpreterInsertQuery.cpp
@@ -304,7 +304,7 @@ BlockIO InterpreterInsertQuery::execute()
 
             /// Actually we don't know structure of input blocks from query/table,
             /// because some clients break insertion protocol (columns != header)
-            out.addSource(std::make_shared<ExpressionTransform>(query_sample_block, adding_missing_defaults_actions));
+            out.addSource(std::make_shared<ConvertingTransform>(query_sample_block, adding_missing_defaults_actions));
 
             /// It's important to squash blocks as early as possible (before other transforms),
             ///  because other transforms may work inefficient if block size is small.
diff --git a/src/Processors/Transforms/ExpressionTransform.cpp b/src/Processors/Transforms/ExpressionTransform.cpp
index 02b3c766f71..ca788f1dd9f 100644
--- a/src/Processors/Transforms/ExpressionTransform.cpp
+++ b/src/Processors/Transforms/ExpressionTransform.cpp
@@ -10,7 +10,7 @@ Block ExpressionTransform::transformHeader(Block header, const ActionsDAG & expr
 
 
 ExpressionTransform::ExpressionTransform(const Block & header_, ExpressionActionsPtr expression_)
-    : ExceptionKeepingTransform(header_, transformHeader(header_, expression_->getActionsDAG()))
+    : ISimpleTransform(header_, transformHeader(header_, expression_->getActionsDAG()), false)
     , expression(std::move(expression_))
 {
 }
@@ -25,4 +25,20 @@ void ExpressionTransform::transform(Chunk & chunk)
     chunk.setColumns(block.getColumns(), num_rows);
 }
 
+ConvertingTransform::ConvertingTransform(const Block & header_, ExpressionActionsPtr expression_)
+    : ExceptionKeepingTransform(header_, ExpressionTransform::transformHeader(header_, expression_->getActionsDAG()))
+    , expression(std::move(expression_))
+{
+}
+
+void ConvertingTransform::transform(Chunk & chunk)
+{
+    size_t num_rows = chunk.getNumRows();
+    auto block = getInputPort().getHeader().cloneWithColumns(chunk.detachColumns());
+
+    expression->execute(block, num_rows);
+
+    chunk.setColumns(block.getColumns(), num_rows);
+}
+
 }
diff --git a/src/Processors/Transforms/ExpressionTransform.h b/src/Processors/Transforms/ExpressionTransform.h
index 0b3fde5147f..a76dc733e14 100644
--- a/src/Processors/Transforms/ExpressionTransform.h
+++ b/src/Processors/Transforms/ExpressionTransform.h
@@ -1,5 +1,6 @@
 #pragma once
 #include <Processors/Transforms/ExceptionKeepingTransform.h>
+#include <Processors/ISimpleTransform.h>
 
 namespace DB
 {
@@ -14,7 +15,7 @@ class ActionsDAG;
   * For example: hits * 2 + 3, url LIKE '%yandex%'
   * The expression processes each row independently of the others.
   */
-class ExpressionTransform final : public ExceptionKeepingTransform
+class ExpressionTransform final : public ISimpleTransform
 {
 public:
     ExpressionTransform(
@@ -32,4 +33,20 @@ private:
     ExpressionActionsPtr expression;
 };
 
+class ConvertingTransform final : public ExceptionKeepingTransform
+{
+public:
+    ConvertingTransform(
+            const Block & header_,
+            ExpressionActionsPtr expression_);
+
+    String getName() const override { return "ConvertingTransform"; }
+
+protected:
+    void transform(Chunk & chunk) override;
+
+private:
+    ExpressionActionsPtr expression;
+};
+
 }