thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-17 21:24:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

modify MaterializeMySQL check MySQL var logical

Browse Source 
Supprot for MySQL 5.7.9: https://github.com/ClickHouse/ClickHouse/issues/4006#issuecomment-817622685
This commit is contained in:
TCeason 2021-04-21 10:13:07 +08:00
parent b43656bf89
commit 51fe9fc771
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/Databases/MySQL/MaterializeMySQLSyncThread.cpp
View File

@ -97,33 +97,30 @@ static void checkMySQLVariables(const mysqlxx::Pool::Entry & connection, const S
{std::make_shared<DataTypeString>(), "Value"}
};
const String & check_query = "SHOW VARIABLES WHERE "
"(Variable_name = 'log_bin' AND upper(Value) = 'ON') "
"OR (Variable_name = 'binlog_format' AND upper(Value) = 'ROW') "
"OR (Variable_name = 'binlog_row_image' AND upper(Value) = 'FULL') "
"OR (Variable_name = 'default_authentication_plugin' AND upper(Value) = 'MYSQL_NATIVE_PASSWORD') "
"OR (Variable_name = 'log_bin_use_v1_row_events' AND upper(Value) = 'OFF');";
const String & check_query = "SHOW VARIABLES;";
StreamSettings mysql_input_stream_settings(settings, false, true);
MySQLBlockInputStream variables_input(connection, check_query, variables_header, mysql_input_stream_settings);
std::unordered_map<String, String> variables_error_message{
{"log_bin", "log_bin = 'ON'"},
{"binlog_format", "binlog_format='ROW'"},
{"binlog_row_image", "binlog_row_image='FULL'"},
{"default_authentication_plugin", "default_authentication_plugin='mysql_native_password'"},
{"log_bin_use_v1_row_events", "log_bin_use_v1_row_events='OFF'"}
{"log_bin", "ON"},
{"binlog_format", "ROW"},
{"binlog_row_image", "FULL"},
{"default_authentication_plugin", "mysql_native_password"},
{"log_bin_use_v1_row_events", "OFF"}
};
while (Block variables_block = variables_input.read())
{
ColumnPtr variable_name_column = variables_block.getByName("Variable_name").column;
ColumnPtr variable_value_column = variables_block.getByName("Value").column;
for (size_t index = 0; index < variables_block.rows(); ++index)
{
const auto & error_message_it = variables_error_message.find(variable_name_column->getDataAt(index).toString());
const String variable_val = variable_value_column->getDataAt(index).toString();
if (error_message_it != variables_error_message.end())
if (error_message_it != variables_error_message.end() && variable_val == error_message_it->second)
variables_error_message.erase(error_message_it);
}
}
@ -133,9 +130,9 @@ static void checkMySQLVariables(const mysqlxx::Pool::Entry & connection, const S
bool first = true;
WriteBufferFromOwnString error_message;
error_message << "Illegal MySQL variables, the MaterializeMySQL engine requires ";
for (const auto & [variable_name, variable_error_message] : variables_error_message)
for (const auto & [variable_name, variable_error_val] : variables_error_message)
{
error_message << (first ? "" : ", ") << variable_error_message;
error_message << (first ? "" : ", ") << variable_name << "='" << variable_error_val << "'";
if (first)
first = false;