thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove clamping from AddDaysImpl and AddWeeksImpl; fix 01921_datatype_date32 test

Browse Source
This commit is contained in:
Roman Vasin 2022-08-10 08:14:16 +00:00
parent 96598e3574
commit 537ba613dc
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Functions/FunctionDateOrDateTimeAddInterval.h
View File

@ -288,12 +288,12 @@ struct AddDaysImpl
static inline NO_SANITIZE_UNDEFINED UInt16 execute(UInt16 d, Int64 delta, const DateLUTImpl &, UInt16 = 0) static inline NO_SANITIZE_UNDEFINED UInt16 execute(UInt16 d, Int64 delta, const DateLUTImpl &, UInt16 = 0)
{ {
return static_cast<UInt16>(std::clamp(d + delta, 0L, 65535L)); return d + delta;
} }
static inline NO_SANITIZE_UNDEFINED Int32 execute(Int32 d, Int64 delta, const DateLUTImpl &, UInt16 = 0) static inline NO_SANITIZE_UNDEFINED Int32 execute(Int32 d, Int64 delta, const DateLUTImpl &, UInt16 = 0)
{ {
return std::max(static_cast<Int32>(d + delta), -static_cast<Int32>(DateLUT::instance().getDayNumOffsetEpoch())); return d + delta;
} }
}; };
@ -322,12 +322,12 @@ struct AddWeeksImpl
static inline NO_SANITIZE_UNDEFINED UInt16 execute(UInt16 d, Int32 delta, const DateLUTImpl &, UInt16 = 0) static inline NO_SANITIZE_UNDEFINED UInt16 execute(UInt16 d, Int32 delta, const DateLUTImpl &, UInt16 = 0)
{ {
return static_cast<UInt16>(std::clamp(d + delta * 7, 0, 65535)); return d + delta * 7;
} }
static inline NO_SANITIZE_UNDEFINED Int32 execute(Int32 d, Int32 delta, const DateLUTImpl &, UInt16 = 0) static inline NO_SANITIZE_UNDEFINED Int32 execute(Int32 d, Int32 delta, const DateLUTImpl &, UInt16 = 0)
{ {
return std::max(static_cast<Int32>(d + delta * 7), -static_cast<Int32>(DateLUT::instance().getDayNumOffsetEpoch())); return d + delta * 7;
} }
}; };

8
tests/queries/0_stateless/01921_datatype_date32.reference
View File

@ -248,14 +248,14 @@
2299-12-30 23:00:00.000 2299-12-30 23:00:00.000
2021-06-21 23:00:00.000 2021-06-21 23:00:00.000
-------subtractDays--------- -------subtractDays---------
1900-01-01 2299-12-31
1900-01-01 2299-12-31
2299-12-08 2299-12-08
2299-12-24 2299-12-24
2021-06-15 2021-06-15
-------subtractWeeks--------- -------subtractWeeks---------
1900-01-01 2299-12-31
1900-01-01 2299-12-31
2299-12-08 2299-12-08
2299-12-24 2299-12-24
2021-06-15 2021-06-15