From 53a3ad609aa60402b26547b295a12768aec9416c Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Sun, 7 Apr 2024 21:32:40 +0200 Subject: [PATCH] Fix trash in documentation --- docs/en/operations/system-tables/asynchronous_metric_log.md | 2 +- src/Common/AsynchronousMetrics.cpp | 2 +- src/Common/AsynchronousMetrics.h | 4 ++-- src/Interpreters/SystemLog.cpp | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/en/operations/system-tables/asynchronous_metric_log.md b/docs/en/operations/system-tables/asynchronous_metric_log.md index e63ab65ba07..e0d3254fe73 100644 --- a/docs/en/operations/system-tables/asynchronous_metric_log.md +++ b/docs/en/operations/system-tables/asynchronous_metric_log.md @@ -3,7 +3,7 @@ slug: /en/operations/system-tables/asynchronous_metric_log --- # asynchronous_metric_log -Contains the historical values for `system.asynchronous_metrics`, which are saved once per minute. Enabled by default. +Contains the historical values for `system.asynchronous_metrics`, which are saved once per time interval (one second by default). Enabled by default. Columns: diff --git a/src/Common/AsynchronousMetrics.cpp b/src/Common/AsynchronousMetrics.cpp index ab54b180fbf..6b26f65deab 100644 --- a/src/Common/AsynchronousMetrics.cpp +++ b/src/Common/AsynchronousMetrics.cpp @@ -56,7 +56,7 @@ static std::unique_ptr openFileIfExists(const std::stri AsynchronousMetrics::AsynchronousMetrics( - int update_period_seconds, + unsigned update_period_seconds, const ProtocolServerMetricsFunc & protocol_server_metrics_func_) : update_period(update_period_seconds) , log(getLogger("AsynchronousMetrics")) diff --git a/src/Common/AsynchronousMetrics.h b/src/Common/AsynchronousMetrics.h index 4b3d28e80c5..b62529a08e7 100644 --- a/src/Common/AsynchronousMetrics.h +++ b/src/Common/AsynchronousMetrics.h @@ -44,7 +44,7 @@ struct ProtocolServerMetrics size_t current_threads; }; -/** Periodically (by default, each minute, starting at 30 seconds offset) +/** Periodically (by default, each second) * calculates and updates some metrics, * that are not updated automatically (so, need to be asynchronously calculated). * @@ -64,7 +64,7 @@ public: using ProtocolServerMetricsFunc = std::function()>; AsynchronousMetrics( - int update_period_seconds, + unsigned update_period_seconds, const ProtocolServerMetricsFunc & protocol_server_metrics_func_); virtual ~AsynchronousMetrics(); diff --git a/src/Interpreters/SystemLog.cpp b/src/Interpreters/SystemLog.cpp index db73fe038c0..3af8761ff8e 100644 --- a/src/Interpreters/SystemLog.cpp +++ b/src/Interpreters/SystemLog.cpp @@ -291,7 +291,7 @@ SystemLogs::SystemLogs(ContextPtr global_context, const Poco::Util::AbstractConf global_context, "system", "filesystem_read_prefetches_log", config, "filesystem_read_prefetches_log", "Contains a history of all prefetches done during reading from MergeTables backed by a remote filesystem."); asynchronous_metric_log = createSystemLog( global_context, "system", "asynchronous_metric_log", config, - "asynchronous_metric_log", "Contains the historical values for system.asynchronous_metrics, which are saved once per minute."); + "asynchronous_metric_log", "Contains the historical values for system.asynchronous_metrics, once per time interval (one second by default)."); opentelemetry_span_log = createSystemLog( global_context, "system", "opentelemetry_span_log", config, "opentelemetry_span_log", "Contains information about trace spans for executed queries.");