thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow constant folding of explicitly forbidden functions

Browse Source
This commit is contained in:
Azat Khuzhin 2021-02-11 00:25:50 +03:00
parent 53a3e178c7
commit 53ea58810e
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Interpreters/ExpressionAnalyzer.cpp
View File

@ -89,6 +89,9 @@ bool allowEarlyConstantFolding(const ActionsDAG & actions, const Settings & sett
{ {
if (node.type == ActionsDAG::ActionType::FUNCTION && node.function_base) if (node.type == ActionsDAG::ActionType::FUNCTION && node.function_base)
{ {
if (!node.function_base->isSuitableForConstantFolding())
return false;
auto name = node.function_base->getName(); auto name = node.function_base->getName();
if (name == "ignore") if (name == "ignore")
return false; return false;

2
tests/queries/0_stateless/01611_constant_folding_subqueries.reference
View File

@ -7,3 +7,5 @@ EXPLAIN SYNTAX SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUI
SELECT SELECT
identity(cast(0, \'UInt64\')) AS n, identity(cast(0, \'UInt64\')) AS n,
toUInt64(10 / n) toUInt64(10 / n)
SELECT * FROM (WITH (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n) as q SELECT * FROM system.one WHERE q > 0);
0

1
tests/queries/0_stateless/01611_constant_folding_subqueries.sql
View File

@ -2,3 +2,4 @@
SELECT * FROM (SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n)) FORMAT CSV; SELECT * FROM (SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n)) FORMAT CSV;
SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n) FORMAT CSV; SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n) FORMAT CSV;
EXPLAIN SYNTAX SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n); EXPLAIN SYNTAX SELECT (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n);
SELECT * FROM (WITH (SELECT * FROM system.numbers LIMIT 1 OFFSET 1) AS n, toUInt64(10 / n) as q SELECT * FROM system.one WHERE q > 0);