mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-27 18:12:02 +00:00
Fix sinks with onException() handler
It is possible to call onException() even after onFinish(), in case of onFinish() throws, and in this case onException() should be no-op for such sinks. Also there can be caveats with PartitionedSync. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
parent
02af58f41d
commit
545a56ce45
@ -418,6 +418,8 @@ public:
|
||||
|
||||
void onException() override
|
||||
{
|
||||
if (!writer)
|
||||
return;
|
||||
onFinish();
|
||||
}
|
||||
|
||||
|
@ -812,6 +812,8 @@ public:
|
||||
|
||||
void onException() override
|
||||
{
|
||||
if (!writer)
|
||||
return;
|
||||
onFinish();
|
||||
}
|
||||
|
||||
|
@ -603,6 +603,8 @@ public:
|
||||
|
||||
void onException() override
|
||||
{
|
||||
if (!writer)
|
||||
return;
|
||||
onFinish();
|
||||
}
|
||||
|
||||
|
@ -445,6 +445,8 @@ void StorageURLSink::consume(Chunk chunk)
|
||||
|
||||
void StorageURLSink::onException()
|
||||
{
|
||||
if (!writer)
|
||||
return;
|
||||
onFinish();
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user