thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-21 09:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed the test

Browse Source 
Previous test version wasn't causing bug on unfixed code, this new one does.
This commit is contained in:
Vasily Nemkov 2021-06-05 00:08:36 +03:00
parent 0ab28360c9
commit 55064e49a7
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Storages/MergeTree/MergeTreeIndexConditionBloomFilter.cpp
View File

@ -420,7 +420,7 @@ bool MergeTreeIndexConditionBloomFilter::traverseASTEquals(
const DataTypePtr actual_type = BloomFilter::getPrimitiveType(array_type->getNestedType());
ColumnPtr column;
{
const auto is_nullable = actual_type->isNullable();
const bool is_nullable = actual_type->isNullable();
auto mutable_column = actual_type->createColumn();
for (const auto & f : value_field.get<Array>())

9
tests/queries/0_stateless/01888_bloom_filter_hasAny.sql
View File

@ -17,6 +17,9 @@ SELECT count() FROM bftest WHERE hasAny(x, [1]) FORMAT Null;
-- can't use bloom_filter with `hasAny` on non-constant arguments (just like `has`)
SELECT count() FROM bftest WHERE hasAny(x, materialize([1,2,3])) FORMAT Null; -- { serverError 277 }
SET force_data_skipping_indices='';
SELECT count() FROM bftest WHERE hasAny(x, materialize([1,2,3])) FORMAT Null;
-- NULLs are not Ok
SELECT count() FROM bftest WHERE hasAny(x, [NULL,-42]) FORMAT Null; -- { serverError 43 }
SELECT count() FROM bftest WHERE hasAny(x, [0,NULL]) FORMAT Null; -- { serverError 43 }
@ -25,6 +28,6 @@ SELECT count() FROM bftest WHERE hasAny(x, [0,NULL]) FORMAT Null; -- { serverErr
SELECT count() FROM bftest WHERE hasAny(x, [[123], -42]) FORMAT Null; -- { serverError 386 }
SELECT count() FROM bftest WHERE hasAny(x, [toDecimal32(123, 3), 2]) FORMAT Null; -- { serverError 53 }
-- Bug discovered by AST fuzzier (shouldn't crash).
SELECT count() FROM bftest WHERE has(x, -0.) OR 0 FORMAT Null;
SELECT count() FROM bftest WHERE hasAny(x, [0, 1]) OR 0 FORMAT Null;
-- Bug discovered by AST fuzzier (fixed, shouldn't crash).
SELECT 1 FROM bftest WHERE has(x, -0.) OR 0. FORMAT Null;
SELECT count() FROM bftest WHERE hasAny(x, [0, 1]) OR 0. FORMAT Null;