thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Demonstrate a regression in parsing S3 URLs

Browse Source 
S3 bucket names are allowed to contain dots
https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html
This commit is contained in:
Kaushik Iska 2024-09-18 18:21:58 +00:00
parent a3fe155579
commit 55602057db
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/IO/tests/gtest_s3_uri.cpp
View File

@ -188,6 +188,14 @@ TEST(S3UriTest, validPatterns)
ASSERT_EQ("", uri.version_id);
ASSERT_EQ(true, uri.is_virtual_hosted_style);
}
{
S3::URI uri("https://bucketname.dots-are-allowed.s3-us-east-2.amazonaws.com/data");
ASSERT_EQ("https://s3-us-east-2.amazonaws.com", uri.endpoint);
ASSERT_EQ("bucketname.dots-are-allowed", uri.bucket);
ASSERT_EQ("data", uri.key);
ASSERT_EQ("", uri.version_id);
ASSERT_EQ(true, uri.is_virtual_hosted_style);
}
{
S3::URI uri("https://s3-us-east-2.amazonaws.com/bucketname/data");
ASSERT_EQ("https://s3-us-east-2.amazonaws.com", uri.endpoint);