thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable DDL ALTER for replicated tables. [#CLICKHOUSE-5]

Browse Source
This commit is contained in:
Vitaliy Lyudvichenko 2017-05-15 00:57:30 +03:00
parent 3a2c1a195d
commit 55aa8217f3
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dbms/src/Interpreters/DDLWorker.cpp
View File

@ -349,6 +349,12 @@ void DDLWorker::processTaskAlter(
if (execute_once_on_replica)
{
/// The following code may perform ALTER twice if
/// current secver aquires lock, executes replicated alter,
/// losts zookeeper connection and doesn't have time to create /executed node, second server executes replicated alter again
/// To avoid this problem alter() method of replicated tables should be changed and takes into account ddl query id tag.
throw Exception("Distributed DDL alters don't work properly yet", ErrorCodes::NOT_IMPLEMENTED);
Strings replica_names;
for (const auto & address : cluster->getShardsWithFailoverAddresses().at(shard_num))
replica_names.emplace_back(address.toString());