thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix tryGetPreparedSet crash when same set expression built from different columns

Browse Source
This commit is contained in:
Duc Canh Le 2022-08-31 21:43:08 +08:00
parent ddac1b3f11
commit 55c20ce45b
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Storages/MergeTree/KeyCondition.cpp
View File

@ -297,8 +297,13 @@ public:
assert(indexes_mapping.size() == data_types.size()); assert(indexes_mapping.size() == data_types.size());
for (size_t i = 0; i < indexes_mapping.size(); ++i) for (size_t i = 0; i < indexes_mapping.size(); ++i)
{
/// Same set expression can be construct from different column(s) with different types
if (indexes_mapping[i].tuple_index >= candidate_set->getDataTypes().size())
return false;
if (!candidate_set->areTypesEqual(indexes_mapping[i].tuple_index, data_types[i])) if (!candidate_set->areTypesEqual(indexes_mapping[i].tuple_index, data_types[i]))
return false; return false;
}
return true; return true;
}; };

1
tests/queries/0_stateless/02416_in_set_same_ast_diff_columns.reference Normal file
View File

@ -0,0 +1 @@
1

3
tests/queries/0_stateless/02416_in_set_same_ast_diff_columns.sql Normal file
View File

@ -0,0 +1,3 @@
CREATE TABLE set_crash (key1 Int32, id1 Int64, c1 Int64) ENGINE = MergeTree PARTITION BY id1 ORDER BY key1;
INSERT INTO set_crash VALUES (-1, 1, 0);
SELECT 1 in (-1,1) FROM set_crash WHERE (key1, id1) in (-1, 1);