thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 07:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix bug when remove unneeded columns in subquery

Browse Source
This commit is contained in:
luocongkai 2022-09-01 17:10:32 +08:00
parent e98ceb2575
commit 56e4179cad
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Interpreters/TreeRewriter.cpp
View File

@ -521,10 +521,15 @@ void removeUnneededColumnsFromSelectClause(ASTSelectQuery * select_query, const
++new_elements_size; ++new_elements_size;
} }
/// removing aggregation can change number of rows, so `count()` result in outer sub-query would be wrong /// removing aggregation can change number of rows, so `count()` result in outer sub-query would be wrong
if (func && AggregateUtils::isAggregateFunction(*func) && !select_query->groupBy()) if (func && !select_query->groupBy())
{ {
new_elements[result_index] = elem; GetAggregatesVisitor::Data data = {};
++new_elements_size; GetAggregatesVisitor(data).visit(elem);
if (!data.aggregates.empty())
{
new_elements[result_index] = elem;
++new_elements_size;
}
} }
} }
} }

1
tests/queries/0_stateless/02131_remove_columns_in_subquery.reference
View File

@ -1 +1,2 @@
1 1
1

3
tests/queries/0_stateless/02131_remove_columns_in_subquery.sql
View File

@ -1 +1,2 @@
select count(1) from (SELECT 1 AS a, count(1) FROM numbers(5)) select count(1) from (SELECT 1 AS a, count(1) FROM numbers(5));
select count(1) from (SELECT 1 AS a, count(1) + 1 FROM numbers(5));