thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 10:02:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not overcommit Buffer memory usage

Browse Source 
During INSERT the check against existing rows and rows from the INSERT
block is performed and if they exceeded threshold the Buffer should be
flushed to avoid overcommit, while before this patch the second check
(in flushBuffer()) will ignore rows from INSERT block.
This commit is contained in:
Azat Khuzhin 2019-12-23 01:35:53 +03:00
parent 8711f98c30
commit 58055e6a94
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dbms/src/Storages/StorageBuffer.cpp
View File

@ -402,7 +402,7 @@ private:
* an exception will be thrown, and new data will not be added to the buffer. * an exception will be thrown, and new data will not be added to the buffer.
*/ */
storage.flushBuffer(buffer, true, true /* locked */); storage.flushBuffer(buffer, false /* check_thresholds */, true /* locked */);
} }
if (!buffer.first_write_time) if (!buffer.first_write_time)