thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 11:32:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always use pread for reading cache segments

Browse Source
This commit is contained in:
Nikita Taranov 2023-12-17 18:37:07 +01:00 committed by GitHub
parent 7f675ddf80
commit 587f829eb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp
View File

@ -177,22 +177,13 @@ CachedOnDiskReadBufferFromFile::getCacheReadBuffer(const FileSegment & file_segm
} }
ReadSettings local_read_settings{settings}; ReadSettings local_read_settings{settings};
local_read_settings.local_fs_prefetch = false;
if (local_read_settings.local_fs_method != LocalFSReadMethod::pread_threadpool)
local_read_settings.local_fs_method = LocalFSReadMethod::pread; local_read_settings.local_fs_method = LocalFSReadMethod::pread;
if (use_external_buffer) if (use_external_buffer)
local_read_settings.local_fs_buffer_size = 0; local_read_settings.local_fs_buffer_size = 0;
cache_file_reader = createReadBufferFromFileBase( cache_file_reader
path, = createReadBufferFromFileBase(path, local_read_settings, std::nullopt, std::nullopt, file_segment.getFlagsForLocalRead());
local_read_settings,
std::nullopt,
std::nullopt,
file_segment.getFlagsForLocalRead(),
/*existing_memory=*/nullptr,
/*alignment=*/0,
/*use_external_buffer=*/true);
if (getFileSizeFromReadBuffer(*cache_file_reader) == 0) if (getFileSizeFromReadBuffer(*cache_file_reader) == 0)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Attempt to read from an empty cache file: {}", path); throw Exception(ErrorCodes::LOGICAL_ERROR, "Attempt to read from an empty cache file: {}", path);