thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle URL without www and scheme for domain and topleveldomain function

Browse Source
This commit is contained in:
Guillaume Tassery 2019-04-18 10:32:42 +07:00
parent 6df315a985
commit 593dcbb33f
3 changed files with 27 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
dbms/src/Functions/domain.h
View File

@ -15,26 +15,32 @@ inline StringRef getURLHost(const char * data, size_t size)
Pos pos = data;
Pos end = data + size;
if (!ignore_scheme || strncmp("www.", data, 4))
if (end == (pos = find_first_symbols<'/'>(pos, end)))
{
if (end == (pos = find_first_symbols<'/'>(pos, end)))
if (ignore_scheme)
pos = data;
else
return {};
if (pos != data)
{
StringRef scheme = getURLScheme(data, size);
Pos scheme_end = data + scheme.size;
// Colon must follows after scheme.
if (pos - scheme_end != 1 || *scheme_end != ':')
return {};
}
if (end - pos < 2 || *(pos) != '/' || *(pos + 1) != '/')
return {};
pos += 2;
}
if (pos != data)
{
StringRef scheme = getURLScheme(data, size);
Pos scheme_end = data + scheme.size;
// Colon must follows after scheme.
if (pos - scheme_end != 1 || *scheme_end != ':')
return {};
}
if (end - pos < 2 || *(pos) != '/' || *(pos + 1) != '/')
{
if (!ignore_scheme)
return {};
}
else
pos += 2;
const char * start_of_host = pos;
for (; pos < end; ++pos)
{

2
dbms/tests/queries/0_stateless/00398_url_functions.reference
View File

@ -15,6 +15,7 @@ www.example.com
www.example.com
example.com
example.com
example.com
====DOMAIN====
com
@ -22,6 +23,7 @@ ru
ru
com
com
com
====PATH====
П
%D%9

4
dbms/tests/queries/0_stateless/00398_url_functions.sql
View File

@ -14,6 +14,7 @@ SELECT domain('http://127.0.0.1:443/') AS Host;
SELECT domain('//www.example.com') AS Host;
SELECT domain('//paul@www.example.com') AS Host;
SELECT domain('www.example.com') as Host;
SELECT domain('example.com') as Host;
SELECT domainWithoutWWW('//paul@www.example.com') AS Host;
SELECT domainWithoutWWW('http://paul@www.example.com:80/') AS Host;
@ -24,7 +25,8 @@ SELECT topLevelDomain('http://127.0.0.1:443/') AS Domain;
SELECT topLevelDomain('svn+ssh://example.ru?q=hello%20world') AS Domain;
SELECT topLevelDomain('svn+ssh://example.ru.?q=hello%20world') AS Domain;
SELECT topLevelDomain('//www.example.com') AS Domain;
SELECT topLevelDomain('www.google.com') as Domain;
SELECT topLevelDomain('www.example.com') as Domain;
SELECT topLevelDomain('example.com') as Domain;
SELECT '====PATH====';
SELECT decodeURLComponent('%D0%9F');