thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix clang tidy warning, add nullptr check (#35540)

Browse Source 
update passing reference instead of pointer in queryHasWithClause based on recommandation

Co-authored-by: larryluogit <larry.luo@ca.ibm.com>
This commit is contained in:
Suzy Wang 2022-04-20 05:26:44 -04:00 committed by GitHub
parent 2c54381520
commit 59f0e83c4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
programs/client/Client.cpp
View File

@ -481,9 +481,9 @@ void Client::printChangedSettings() const
}
static bool queryHasWithClause(const IAST * ast)
static bool queryHasWithClause(const IAST & ast)
{
if (const auto * select = dynamic_cast<const ASTSelectQuery *>(ast); select && select->with())
if (const auto * select = dynamic_cast<const ASTSelectQuery *>(&ast); select && select->with())
{
return true;
}
@ -493,12 +493,9 @@ static bool queryHasWithClause(const IAST * ast)
// breakage when the AST structure changes and some new variant of query
// nesting is added. This function is used in fuzzer, so it's better to be
// defensive and avoid weird unexpected errors.
// clang-tidy is confused by this function: it thinks that if `select` is
// nullptr, `ast` is also nullptr, and complains about nullptr dereference.
// NOLINTNEXTLINE
for (const auto & child : ast->children)
for (const auto & child : ast.children)
{
if (queryHasWithClause(child.get()))
if (queryHasWithClause(*child))
{
return true;
}
@ -722,7 +719,7 @@ bool Client::processWithFuzzing(const String & full_query)
// query, but second and third.
// If you have to add any more workarounds to this check, just remove
// it altogether, it's not so useful.
if (!have_error && !queryHasWithClause(parsed_query.get()))
if (parsed_query && !have_error && !queryHasWithClause(*parsed_query))
{
ASTPtr ast_2;
try