From 5a5792259cce880ff20180b6f42ca07b632440cb Mon Sep 17 00:00:00 2001 From: alesapin Date: Fri, 28 Feb 2020 11:55:17 +0300 Subject: [PATCH] Finalize mutations more frequently --- dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp b/dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp index 7ba4e756de1..9925a176540 100644 --- a/dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp +++ b/dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp @@ -1345,7 +1345,11 @@ bool ReplicatedMergeTreeQueue::tryFinalizeMutations(zkutil::ZooKeeperPtr zookeep } } - return candidates.size() != finished.size(); + /// Mutations may finish in non sequential order because we may fetch + /// already mutated parts from other replicas. So, because we updated + /// mutation pointer we have to recheck all previous mutations, they may be + /// also finished. + return !finished.empty(); }