thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #25314 from ClickHouse/fix-ubsan-quantile-timing

Browse Source 
Fix UBSan report in quantileTiming
This commit is contained in:
alexey-milovidov 2021-06-17 01:24:24 +03:00 committed by GitHub
commit 5de9f6cdca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/AggregateFunctions/AggregateFunctionQuantile.h
View File

@ -113,8 +113,8 @@ public:
if constexpr (std::is_same_v<Data, QuantileTiming<Value>>)
{
/// QuantileTiming only supports integers.
if (isNaN(value) || value > std::numeric_limits<Value>::max() || value < std::numeric_limits<Value>::min())
/// QuantileTiming only supports unsigned integers. Too large values are also meaningless.
if (isNaN(value) || value > std::numeric_limits<Int64>::max() || value < 0)
return;
}

1
tests/queries/0_stateless/01914_ubsan_quantile_timing.reference Normal file
View File

@ -0,0 +1 @@
0

1
tests/queries/0_stateless/01914_ubsan_quantile_timing.sql Normal file
View File

@ -0,0 +1 @@
SELECT quantileTiming(-0.)(number / 1.1754943508222875e-38) FROM numbers(257);