thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add file paths into logs on failed distributed async sends

Browse Source
This commit is contained in:
Azat Khuzhin 2021-05-01 11:22:04 +03:00
parent 08f10dced0
commit 5e33604c4d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Storages/Distributed/DirectoryMonitor.cpp
View File

@ -562,8 +562,9 @@ void StorageDistributedDirectoryMonitor::processFile(const std::string & file_pa
writeRemoteConvert(distributed_header, remote, compression_expected, in, log);
remote.writeSuffix();
}
catch (const Exception & e)
catch (Exception & e)
{
e.addMessage(fmt::format("While sending {}", file_path));
maybeMarkAsBroken(file_path, e);
throw;
}
@ -711,7 +712,7 @@ struct StorageDistributedDirectoryMonitor::Batch
if (remote)
remote->writeSuffix();
}
catch (const Exception & e)
catch (Exception & e)
{
if (isFileBrokenErrorCode(e.code(), e.isRemoteException()))
{
@ -719,7 +720,14 @@ struct StorageDistributedDirectoryMonitor::Batch
batch_broken = true;
}
else
{
std::vector<std::string> files(file_index_to_path.size());
for (const auto & [index, name] : file_index_to_path)
files.push_back(name);
e.addMessage(fmt::format("While sending batch {}", fmt::join(files, "\n")));
throw;
}
}
if (!batch_broken)