thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak

Browse Source
This commit is contained in:
kssenii 2024-07-01 15:40:49 +02:00
parent fbdbbf5a78
commit 5e7a8245c4
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Storages/ObjectStorage/DataLakes/DeltaLakeMetadata.cpp
View File

@ -51,8 +51,10 @@ namespace ErrorCodes
extern const int NOT_IMPLEMENTED;
}
struct DeltaLakeMetadata::Impl
struct DeltaLakeMetadataImpl
{
using ConfigurationPtr = DeltaLakeMetadata::ConfigurationPtr;
ObjectStoragePtr object_storage;
ConfigurationPtr configuration;
ContextPtr context;
@ -61,7 +63,7 @@ struct DeltaLakeMetadata::Impl
* Useful links:
* - https://github.com/delta-io/delta/blob/master/PROTOCOL.md#data-files
*/
Impl(ObjectStoragePtr object_storage_,
DeltaLakeMetadataImpl(ObjectStoragePtr object_storage_,
ConfigurationPtr configuration_,
ContextPtr context_)
: object_storage(object_storage_)
@ -586,14 +588,14 @@ DeltaLakeMetadata::DeltaLakeMetadata(
ObjectStoragePtr object_storage_,
ConfigurationPtr configuration_,
ContextPtr context_)
: impl(std::make_unique<Impl>(object_storage_, configuration_, context_))
{
auto result = impl->processMetadataFiles();
auto impl = DeltaLakeMetadataImpl(object_storage_, configuration_, context_);
auto result = impl.processMetadataFiles();
data_files = result.data_files;
schema = result.schema;
partition_columns = result.partition_columns;
LOG_TRACE(impl->log, "Found {} data files, {} partition files, schema: {}",
LOG_TRACE(impl.log, "Found {} data files, {} partition files, schema: {}",
data_files.size(), partition_columns.size(), schema.toString());
}

3
src/Storages/ObjectStorage/DataLakes/DeltaLakeMetadata.h
View File

@ -45,10 +45,7 @@ public:
}
private:
struct Impl;
const std::shared_ptr<Impl> impl;
mutable Strings data_files;
NamesAndTypesList schema;
std::unordered_map<String, String> column_name_to_physical_name;
DataLakePartitionColumns partition_columns;