thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-14 18:32:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove fixme

Browse Source
This commit is contained in:
kssenii 2023-03-22 17:37:49 +01:00
parent 5b7f214ea9
commit 5ee5e2c339
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Interpreters/Cache/FileCache.cpp
View File

@ -591,9 +591,8 @@ void FileCache::iterateCacheAndCollectKeyLocks(
void FileCache::removeFileSegment(LockedKey & locked_key, FileSegmentPtr file_segment, const CacheGuard::Lock & cache_lock)
{
/// FIXME:
/// We must hold pointer to file segment while removing it (because we remove file segment under file segment lock).
/// But this should not be obligatory.
/// We must hold pointer to file segment while removing it
/// (because we remove file segment under file segment lock).
chassert(file_segment->key() == locked_key.getKey());
locked_key.removeFileSegment(file_segment->offset(), file_segment->lock(), cache_lock);