thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-14 18:32:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
János Benjamin Antal 2024-04-02 10:48:08 +00:00
parent cf5517a099
commit 5f676999ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
View File

@ -236,7 +236,6 @@ void ReplicatedMergeTreeQueue::removeDropReplaceIntent(const MergeTreePartInfo &
bool ReplicatedMergeTreeQueue::isIntersectingWithDropReplaceIntent( bool ReplicatedMergeTreeQueue::isIntersectingWithDropReplaceIntent(
const LogEntry & entry, const String & part_name, String & out_reason, std::unique_lock<std::mutex> & /*state_mutex lock*/) const const LogEntry & entry, const String & part_name, String & out_reason, std::unique_lock<std::mutex> & /*state_mutex lock*/) const
{ {
// TODO(antaljanosbenjamin): fill out out_reason
const auto part_info = MergeTreePartInfo::fromPartName(part_name, format_version); const auto part_info = MergeTreePartInfo::fromPartName(part_name, format_version);
for (const auto & intent : drop_replace_range_intents) for (const auto & intent : drop_replace_range_intents)
{ {
@ -252,6 +251,7 @@ bool ReplicatedMergeTreeQueue::isIntersectingWithDropReplaceIntent(
entry.new_part_name, entry.new_part_name,
part_name, part_name,
intent.getPartNameForLogs()); intent.getPartNameForLogs());
return true;
} }
} }
return false; return false;