code review

This commit is contained in:
vicgao 2021-11-08 15:14:45 +08:00
parent ec2c70ab75
commit 6020c23145
2 changed files with 8 additions and 2 deletions

View File

@ -91,8 +91,8 @@ BlockIO InterpreterRenameQuery::executeToTables(const ASTRenameQuery & rename, c
}
else
{
ignore = rename.dictionary ? (!database_catalog.isDictionaryExist(StorageID(elem.to_database_name, elem.to_table_name))) :
(!database_catalog.isTableExist(StorageID(elem.to_database_name, elem.to_table_name), getContext()));
ignore = rename.dictionary ? (!database_catalog.isDictionaryExist(StorageID(elem.from_database_name, elem.from_table_name))) :
(!database_catalog.isTableExist(StorageID(elem.from_database_name, elem.from_table_name), getContext()));
}
}

View File

@ -73,6 +73,10 @@ protected:
if (database)
{
settings.ostr << (settings.hilite ? hilite_keyword : "") << "RENAME DATABASE " << (settings.hilite ? hilite_none : "");
if (elements.at(0).if_exists)
settings.ostr << "IF EXISTS ";
settings.ostr << backQuoteIfNeed(elements.at(0).from.database);
settings.ostr << (settings.hilite ? hilite_keyword : "") << " TO " << (settings.hilite ? hilite_none : "");
settings.ostr << backQuoteIfNeed(elements.at(0).to.database);
@ -97,6 +101,8 @@ protected:
if (it != elements.cbegin())
settings.ostr << ", ";
if (it->if_exists)
settings.ostr << "IF EXISTS ";
settings.ostr << (!it->from.database.empty() ? backQuoteIfNeed(it->from.database) + "." : "") << backQuoteIfNeed(it->from.table)
<< (settings.hilite ? hilite_keyword : "") << (exchange ? " AND " : " TO ") << (settings.hilite ? hilite_none : "")
<< (!it->to.database.empty() ? backQuoteIfNeed(it->to.database) + "." : "") << backQuoteIfNeed(it->to.table);