thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-14 18:32:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Do not segfault on empty first_bucket & totals

Browse Source
This commit is contained in:
Sergey Skvortsov 2022-06-18 01:38:50 +03:00
parent 29b6be9a00
commit 60aabafdfa
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Interpreters/GraceHashJoin.cpp
View File

@ -369,8 +369,9 @@ size_t GraceHashJoin::getTotalByteCount() const
bool GraceHashJoin::alwaysReturnsEmptySet() const bool GraceHashJoin::alwaysReturnsEmptySet() const
{ {
auto snapshot = buckets.get(); auto snapshot = buckets.get();
bool all_buckets_are_empty = std::all_of(snapshot->begin(), snapshot->end(), [](const auto & bucket) { return bucket->empty(); }); bool file_buckets_are_empty = std::all_of(snapshot->begin(), snapshot->end(), [](const auto & bucket) { return bucket->empty(); });
return isInnerOrRight(table_join->kind()) && first_bucket->alwaysReturnsEmptySet() && all_buckets_are_empty; bool first_bucket_is_empty = first_bucket && first_bucket->alwaysReturnsEmptySet();
return isInnerOrRight(table_join->kind()) && first_bucket_is_empty && file_buckets_are_empty;
} }
std::shared_ptr<NotJoinedBlocks> GraceHashJoin::getNonJoinedBlocks(const Block &, const Block &, UInt64) const std::shared_ptr<NotJoinedBlocks> GraceHashJoin::getNonJoinedBlocks(const Block &, const Block &, UInt64) const