thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

check-style: add a check for ReplicatedMergeTree in *.sql

Browse Source
This commit is contained in:
Azat Khuzhin 2021-08-04 10:11:25 +03:00
parent 3d347065a8
commit 617cdd5d4d
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
utils/check-style/check-style
View File

@ -132,14 +132,8 @@ for test_case in "${tests_with_replicated_merge_tree[@]}"; do
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
;;
*.sql)
# NOTE: *.sql is not supported because it is not possible right now, because:
# - ReplicatedMergeTree supports only ASTLiteral for zookeeper path
# (and adding support of other nodes, with evaluating them are not that easy, due to zk_prefix is "optional")
# - Hence concat(currentDatabase(), 'foo')
# - Also params cannot be used, because the are wrapped with CAST()
#
# But hopefully they will not be a problem
# (since they do not do any "stressing" and overlap probability should be lower).
test_case_zk_prefix="{[ ]*database[ ]*}"
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
;;
*.py)
# Right now there is not such tests anyway