thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

More informative assert

Browse Source
This commit is contained in:
kssenii 2024-11-13 12:55:39 +01:00
parent b219be523d
commit 626f49df4c
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp
View File

@ -470,7 +470,7 @@ CachedOnDiskReadBufferFromFile::ReadFromFileSegmentStatePtr CachedOnDiskReadBuff
ReadInfo & info,
LoggerPtr log)
{
chassert(!file_segment.isDownloader());
chassert(!file_segment.isDownloader(), getInfoForLog(nullptr, info, offset));
chassert(offset >= file_segment.range().left);
auto range = file_segment.range();
@ -813,7 +813,7 @@ bool CachedOnDiskReadBufferFromFile::updateImplementationBufferIfNeeded()
auto current_state = file_segment.state();
chassert(current_read_range.left <= file_offset_of_buffer_end);
chassert(!file_segment.isDownloader());
chassert(!file_segment.isDownloader(), getInfoForLog());
if (file_offset_of_buffer_end > current_read_range.right)
{
@ -950,7 +950,7 @@ bool CachedOnDiskReadBufferFromFile::nextImplStep()
if (use_external_buffer && !internal_buffer.empty())
internal_buffer.resize(original_buffer_size);
chassert(!file_segment.isDownloader());
chassert(!file_segment.isDownloader(), getInfoForLog());
}
catch (...)
{
@ -1204,10 +1204,12 @@ size_t CachedOnDiskReadBufferFromFile::readFromFileSegment(
}
// No necessary because of the SCOPE_EXIT above, but useful for logging below.
if (do_download && reset_downloader_after_read)
if (reset_downloader_after_read)
{
file_segment.completePartAndResetDownloader();
chassert(!file_segment.isDownloader());
if (do_download)
file_segment.completePartAndResetDownloader();
chassert(!file_segment.isDownloader(), getInfoForLog(&state, info, offset));
}
LOG_TEST(log, "Read {} bytes. Read info: {}", size, getInfoForLog(&state, info, offset));