Enabling -Wextra-semi [#CLICKHOUSE-2]

This commit is contained in:
Alexey Milovidov 2018-08-26 03:50:48 +03:00
parent 52eb8fda3c
commit 6605098439
5 changed files with 16 additions and 16 deletions

View File

@ -3430,7 +3430,7 @@ void FunctionArrayIntersect::NumberExecutor::operator()()
if (!result && typeid_cast<const DataTypeNumber<T> *>(data_type.get())) if (!result && typeid_cast<const DataTypeNumber<T> *>(data_type.get()))
result = execute<Map, ColumnVector<T>, true>(arrays, ColumnVector<T>::create()); result = execute<Map, ColumnVector<T>, true>(arrays, ColumnVector<T>::create());
}; }
template <typename Map, typename ColumnType, bool is_numeric_column> template <typename Map, typename ColumnType, bool is_numeric_column>
ColumnPtr FunctionArrayIntersect::execute(const UnpackedArrays & arrays, MutableColumnPtr result_data_ptr) ColumnPtr FunctionArrayIntersect::execute(const UnpackedArrays & arrays, MutableColumnPtr result_data_ptr)

View File

@ -1452,7 +1452,7 @@ class FunctionArrayConcat : public IFunction
public: public:
static constexpr auto name = "arrayConcat"; static constexpr auto name = "arrayConcat";
static FunctionPtr create(const Context & context); static FunctionPtr create(const Context & context);
FunctionArrayConcat(const Context & context) : context(context) {}; FunctionArrayConcat(const Context & context) : context(context) {}
String getName() const override; String getName() const override;
@ -1579,7 +1579,7 @@ class FunctionArrayIntersect : public IFunction
public: public:
static constexpr auto name = "arrayIntersect"; static constexpr auto name = "arrayIntersect";
static FunctionPtr create(const Context & context); static FunctionPtr create(const Context & context);
FunctionArrayIntersect(const Context & context) : context(context) {}; FunctionArrayIntersect(const Context & context) : context(context) {}
String getName() const override; String getName() const override;
@ -1681,7 +1681,7 @@ class FunctionArrayResize : public IFunction
public: public:
static constexpr auto name = "arrayResize"; static constexpr auto name = "arrayResize";
static FunctionPtr create(const Context & context); static FunctionPtr create(const Context & context);
FunctionArrayResize(const Context & context) : context(context) {}; FunctionArrayResize(const Context & context) : context(context) {}
String getName() const override; String getName() const override;

View File

@ -92,7 +92,7 @@ public:
static FunctionPtr create(const Context &) static FunctionPtr create(const Context &)
{ {
return std::make_shared<FunctionConsistentHashImpl<Impl>>(); return std::make_shared<FunctionConsistentHashImpl<Impl>>();
}; }
String getName() const override String getName() const override
{ {

View File

@ -907,7 +907,7 @@ class FunctionToFixedString : public IFunction
{ {
public: public:
static constexpr auto name = "toFixedString"; static constexpr auto name = "toFixedString";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionToFixedString>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionToFixedString>(); }
String getName() const override String getName() const override
{ {
@ -1531,7 +1531,7 @@ private:
throw Exception{"Enum conversion changes value for element '" + name_value.first + throw Exception{"Enum conversion changes value for element '" + name_value.first +
"' from " + toString(old_value) + " to " + toString(new_value), ErrorCodes::CANNOT_CONVERT_TYPE}; "' from " + toString(old_value) + " to " + toString(new_value), ErrorCodes::CANNOT_CONVERT_TYPE};
} }
}; }
template <typename ColumnStringType, typename EnumType> template <typename ColumnStringType, typename EnumType>
WrapperType createStringToEnumWrapper() const WrapperType createStringToEnumWrapper() const

View File

@ -623,7 +623,7 @@ class FunctionDateOrDateTimeToSomething : public IFunction
{ {
public: public:
static constexpr auto name = Transform::name; static constexpr auto name = Transform::name;
static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateOrDateTimeToSomething>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateOrDateTimeToSomething>(); }
String getName() const override String getName() const override
{ {
@ -928,7 +928,7 @@ class FunctionDateOrDateTimeAddInterval : public IFunction
{ {
public: public:
static constexpr auto name = Transform::name; static constexpr auto name = Transform::name;
static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateOrDateTimeAddInterval>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateOrDateTimeAddInterval>(); }
String getName() const override String getName() const override
{ {
@ -1015,7 +1015,7 @@ class FunctionDateDiff : public IFunction
{ {
public: public:
static constexpr auto name = "dateDiff"; static constexpr auto name = "dateDiff";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateDiff>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionDateDiff>(); }
String getName() const override String getName() const override
{ {
@ -1192,7 +1192,7 @@ class FunctionNow : public IFunction
{ {
public: public:
static constexpr auto name = "now"; static constexpr auto name = "now";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionNow>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionNow>(); }
String getName() const override String getName() const override
{ {
@ -1221,7 +1221,7 @@ class FunctionToday : public IFunction
{ {
public: public:
static constexpr auto name = "today"; static constexpr auto name = "today";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionToday>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionToday>(); }
String getName() const override String getName() const override
{ {
@ -1250,7 +1250,7 @@ class FunctionYesterday : public IFunction
{ {
public: public:
static constexpr auto name = "yesterday"; static constexpr auto name = "yesterday";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionYesterday>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionYesterday>(); }
String getName() const override String getName() const override
{ {
@ -1280,7 +1280,7 @@ class FunctionToTimeZone : public IFunction
{ {
public: public:
static constexpr auto name = "toTimeZone"; static constexpr auto name = "toTimeZone";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionToTimeZone>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionToTimeZone>(); }
String getName() const override String getName() const override
{ {
@ -1315,7 +1315,7 @@ class FunctionTimeSlot : public IFunction
{ {
public: public:
static constexpr auto name = "timeSlot"; static constexpr auto name = "timeSlot";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionTimeSlot>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionTimeSlot>(); }
String getName() const override String getName() const override
{ {
@ -1442,7 +1442,7 @@ class FunctionTimeSlots : public IFunction
{ {
public: public:
static constexpr auto name = "timeSlots"; static constexpr auto name = "timeSlots";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionTimeSlots>(); }; static FunctionPtr create(const Context &) { return std::make_shared<FunctionTimeSlots>(); }
String getName() const override String getName() const override
{ {