thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18912 from sundy-li/bitmapOrCardinality-nullfix

Browse Source 
Fix bitmapOrCardinality using wrong variable
This commit is contained in:
alexey-milovidov 2021-01-11 14:28:46 +03:00 committed by GitHub
commit 667dd0cf0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/AggregateFunctions/AggregateFunctionGroupBitmapData.h
View File

@ -168,7 +168,7 @@ public:
{
for (const auto & x : small)
{
if (rb->contains(static_cast<Value>(x.getValue())))
if (r1.rb->contains(static_cast<Value>(x.getValue())))
buffer.push_back(x.getValue());
}
@ -264,7 +264,7 @@ public:
{
for (const auto & x : small)
{
if (rb->contains(static_cast<Value>(x.getValue())))
if (r1.rb->contains(static_cast<Value>(x.getValue())))
++ret;
}
}

36
tests/queries/0_stateless/00829_bitmap_function.sql
View File

@ -309,3 +309,39 @@ select bitmapMax(bitmapBuild([1,5,7,9]));
select bitmapMax(bitmapBuild([
0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,
100,200,500]));
-- reproduce #18911
CREATE TABLE bitmap_test(pickup_date Date, city_id UInt32, uid UInt32)ENGINE = Memory;
INSERT INTO bitmap_test SELECT '2019-01-01', 1, number FROM numbers(1,50);
INSERT INTO bitmap_test SELECT '2019-01-02', 1, number FROM numbers(11,60);
INSERT INTO bitmap_test SELECT '2019-01-03', 2, number FROM numbers(1,10);
SELECT
bitmapCardinality(day_today) AS today_users,
bitmapCardinality(day_before) AS before_users,
bitmapOrCardinality(day_today, day_before) AS all_users,
bitmapAndCardinality(day_today, day_before) AS old_users,
bitmapAndnotCardinality(day_today, day_before) AS new_users,
bitmapXorCardinality(day_today, day_before) AS diff_users
FROM
(
SELECT
city_id,
groupBitmapState(uid) AS day_today
FROM bitmap_test
WHERE pickup_date = '2019-01-02'
GROUP BY
rand((rand((rand('') % nan) = NULL) % 7) % rand(NULL)),
city_id
) AS js1
ALL LEFT JOIN
(
SELECT
city_id,
groupBitmapState(uid) AS day_before
FROM bitmap_test
WHERE pickup_date = '2019-01-01'
GROUP BY city_id
) AS js2 USING (city_id) FORMAT Null;
drop table bitmap_test;