thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #70371 from ClickHouse/backport/24.8/70338

Browse Source 
Backport #70338 to 24.8: Fix crash when using WITH FILL incorrectly
This commit is contained in:
robot-ch-test-poll2 2024-10-04 18:34:52 +04:00 committed by GitHub
commit 66bf2a0bf6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Analyzer/Resolve/QueryAnalyzer.cpp
View File

@ -3992,9 +3992,10 @@ ProjectionNames QueryAnalyzer::resolveSortNodeList(QueryTreeNodePtr & sort_node_
const auto * constant_node = sort_node.getFillTo()->as<ConstantNode>();
if (!constant_node || !isColumnedAsNumber(constant_node->getResultType()))
throw Exception(ErrorCodes::INVALID_WITH_FILL_EXPRESSION,
throw Exception(
ErrorCodes::INVALID_WITH_FILL_EXPRESSION,
"Sort FILL TO expression must be constant with numeric type. Actual {}. In scope {}",
sort_node.getFillFrom()->formatASTForErrorMessage(),
sort_node.getFillTo()->formatASTForErrorMessage(),
scope.scope_node->formatASTForErrorMessage());
size_t fill_to_expression_projection_names_size = fill_to_expression_projection_names.size();

0
tests/queries/0_stateless/03248_with_fill_string_crash.reference Normal file
View File

7
tests/queries/0_stateless/03248_with_fill_string_crash.sql Normal file
View File

@ -0,0 +1,7 @@
CREATE TABLE users (date DateTime, name String, age Int16) ENGINE=MergeTree() ORDER BY date;
INSERT INTO users VALUES ('2024-01-01', 'John', 33),
('2024-02-01', 'Ksenia', 48),
('2024-02-15', 'Alice', 50);
SELECT * FROM users ORDER BY date WITH FILL TO '2024-02-17' STEP toIntervalHour(1); -- { serverError INVALID_WITH_FILL_EXPRESSION }