thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-18 12:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #73082 from Avogar/fix-tuple-duplicate-json-key

Browse Source 
Check for duplicate JSON keys during Tuple parsing
This commit is contained in:
Pavel Kruglov 2024-12-11 10:57:42 +00:00 committed by GitHub
commit 66eecb112f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/DataTypes/Serializations/SerializationTuple.cpp
View File

@ -400,6 +400,9 @@ ReturnType SerializationTuple::deserializeTupleJSONImpl(IColumn & column, ReadBu
return false; return false;
} }
if (seen_elements[element_pos])
throw Exception(ErrorCodes::INCORRECT_DATA, "JSON object contains duplicate key '{}'", name);
seen_elements[element_pos] = 1; seen_elements[element_pos] = 1;
auto & element_column = extractElementColumn(column, element_pos); auto & element_column = extractElementColumn(column, element_pos);

2
tests/queries/0_stateless/03284_json_object_as_tuple_duplicate_keys.reference Normal file
View File

@ -0,0 +1,2 @@
a Tuple(\n b Nullable(String))
a Tuple(\n b Nullable(String))

9
tests/queries/0_stateless/03284_json_object_as_tuple_duplicate_keys.sql Normal file
View File

@ -0,0 +1,9 @@
select * from format(JSONEachRow, 'a Tuple(b UInt32)', '{"a" : {"b" : 1, "b" : 2}}'); -- {serverError INCORRECT_DATA}
select * from format(JSONEachRow, '{"a" : {"b" : 1, "b" : 2}}'); -- {serverError INCORRECT_DATA}
select * from format(JSONEachRow, '{"a" : {"b" : 1, "b" : 2, "b" : 3}, "c" : 42}'); -- {serverError INCORRECT_DATA}
set input_format_json_use_string_type_for_ambiguous_paths_in_named_tuples_inference_from_objects=1;
desc format(JSONEachRow, '{"a" : {"b" : 1, "b" : "Hello"}}');
select * from format(JSONEachRow, '{"a" : {"b" : 1, "b" : "Hello"}}'); -- {serverError INCORRECT_DATA}
desc format(JSONEachRow, '{"a" : {"b" : 1, "b" : {"c" : "Hello"}}}');
select * from format(JSONEachRow, '{"a" : {"b" : 1, "b" : {"c" : "Hello"}}}'); -- {serverError INCORRECT_DATA}