thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix executable user default functions execution with Nullable arguments

Browse Source
This commit is contained in:
Maksim Kita 2022-05-31 18:46:33 +02:00
parent bacee7f19c
commit 66f43b9ad3
4 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Interpreters/UserDefinedExecutableFunctionFactory.cpp
View File

@ -43,7 +43,7 @@ public:
size_t getNumberOfArguments() const override { return executable_function->getConfiguration().arguments.size(); }
bool useDefaultImplementationForConstants() const override { return true; }
bool useDefaultImplementationForNulls() const override { return true; }
bool useDefaultImplementationForNulls() const override { return false; }
bool isDeterministic() const override { return false; }
bool isDeterministicInScopeOfQuery() const override { return false; }

22
tests/integration/test_executable_user_defined_function/functions/test_function_config.xml
View File

@ -289,4 +289,26 @@
<command>input_sum_json_named_args.py</command>
</function>
<function>
<type>executable</type>
<name>test_function_nullable_python</name>
<return_type>String</return_type>
<argument>
<type>Nullable(UInt64)</type>
</argument>
<format>TabSeparated</format>
<command>input_nullable.py</command>
</function>
<function>
<type>executable</type>
<name>test_function_nullable_pool_python</name>
<return_type>String</return_type>
<argument>
<type>Nullable(UInt64)</type>
</argument>
<format>TabSeparated</format>
<command>input_nullable.py</command>
</function>
</functions>

12
tests/integration/test_executable_user_defined_function/test.py
View File

@ -228,3 +228,15 @@ def test_executable_function_sum_json_python(started_cluster):
)
node.query("DROP TABLE test_table;")
def test_executable_function_input_nullable_python(started_cluster):
skip_test_msan(node)
node.query("CREATE TABLE test_table_nullable (value Nullable(UInt64)) ENGINE=TinyLog;")
node.query("INSERT INTO test_table_nullable VALUES (0), (NULL), (2);")
assert(node.query("SELECT test_function_nullable_python(1), test_function_nullable_python(NULL)") == "Key 1\tKey Nullable\n")
assert(node.query("SELECT test_function_nullable_python(value) FROM test_table_nullable;") == "Key 0\nKey Nullable\nKey 2\n")
assert(node.query("SELECT test_function_nullable_pool_python(1), test_function_nullable_pool_python(NULL)") == "Key 1\tKey Nullable\n")
assert(node.query("SELECT test_function_nullable_pool_python(value) FROM test_table_nullable;") == "Key 0\nKey Nullable\nKey 2\n")

12
tests/integration/test_executable_user_defined_function/user_scripts/input_nullable.py Executable file
View File

@ -0,0 +1,12 @@
#!/usr/bin/python3
import sys
if __name__ == "__main__":
for line in sys.stdin:
if (line == "\\N\n"):
print("Key Nullable", end="\n")
else:
print("Key " + line, end="")
sys.stdout.flush()