thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 03:12:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix alter named collection if exists

Browse Source
This commit is contained in:
Илья Коргун 2023-07-27 23:30:21 +03:00
parent ae4406cd80
commit 686ed14e71
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Common/NamedCollections/NamedCollectionUtils.cpp
View File

@ -428,9 +428,21 @@ void updateFromSQL(const ASTAlterNamedCollectionQuery & query, ContextPtr contex
{ {
auto lock = lockNamedCollectionsTransaction(); auto lock = lockNamedCollectionsTransaction();
loadIfNotUnlocked(lock); loadIfNotUnlocked(lock);
auto & instance = NamedCollectionFactory::instance();
if (!instance.exists(query.collection_name))
{
if (!query.if_exists)
{
throw Exception(
ErrorCodes::NAMED_COLLECTION_DOESNT_EXIST,
"Cannot remove collection `{}`, because it doesn't exist",
query.collection_name);
}
return;
}
LoadFromSQL(context).update(query); LoadFromSQL(context).update(query);
auto collection = NamedCollectionFactory::instance().getMutable(query.collection_name); auto collection = instance.getMutable(query.collection_name);
auto collection_lock = collection->lock(); auto collection_lock = collection->lock();
for (const auto & [name, value] : query.changes) for (const auto & [name, value] : query.changes)