thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove dead code in needRewrite function

Browse Source
This commit is contained in:
vdimir 2022-03-28 13:42:04 +00:00
parent cda8a18fe3
commit 69160fa3e3
No known key found for this signature in database
GPG Key ID: 6EE4CE2BEDC51862
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Interpreters/JoinToSubqueryTransformVisitor.cpp
View File

@ -182,7 +182,6 @@ struct RewriteTablesVisitorData
} }
}; };
template <size_t version = 1>
bool needRewrite(ASTSelectQuery & select, std::vector<const ASTTableExpression *> & table_expressions) bool needRewrite(ASTSelectQuery & select, std::vector<const ASTTableExpression *> & table_expressions)
{ {
if (!select.tables()) if (!select.tables())
@ -233,8 +232,6 @@ bool needRewrite(ASTSelectQuery & select, std::vector<const ASTTableExpression *
return false; return false;
/// it's not trivial to support mix of JOIN ON & JOIN USING cause of short names /// it's not trivial to support mix of JOIN ON & JOIN USING cause of short names
if (num_using && version <= 1)
throw Exception("Multiple JOIN does not support USING", ErrorCodes::NOT_IMPLEMENTED);
if (num_array_join) if (num_array_join)
throw Exception("Multiple JOIN does not support mix with ARRAY JOINs", ErrorCodes::NOT_IMPLEMENTED); throw Exception("Multiple JOIN does not support mix with ARRAY JOINs", ErrorCodes::NOT_IMPLEMENTED);
return true; return true;
@ -605,7 +602,7 @@ void JoinToSubqueryTransformMatcher::visit(ASTPtr & ast, Data & data)
void JoinToSubqueryTransformMatcher::visit(ASTSelectQuery & select, ASTPtr & ast, Data & data) void JoinToSubqueryTransformMatcher::visit(ASTSelectQuery & select, ASTPtr & ast, Data & data)
{ {
std::vector<const ASTTableExpression *> table_expressions; std::vector<const ASTTableExpression *> table_expressions;
if (!needRewrite<2>(select, table_expressions)) if (!needRewrite(select, table_expressions))
return; return;
auto & src_tables = select.tables()->children; auto & src_tables = select.tables()->children;