From 2b7346d755cf003bf3ba87bac7df275c568080d4 Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Thu, 9 Nov 2023 23:37:18 +0100 Subject: [PATCH 1/2] Better warning message --- src/Interpreters/Context.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Interpreters/Context.cpp b/src/Interpreters/Context.cpp index 138741a2f2b..ac552a3969c 100644 --- a/src/Interpreters/Context.cpp +++ b/src/Interpreters/Context.cpp @@ -846,7 +846,7 @@ Strings Context::getWarnings() const } res = res + "]" + (single_element ? " is" : " are") + " changed. " - "Please check 'select * from system.settings where changed and is_obsolete' and read the changelog."; + "Please check 'SELECT * FROM system.settings WHERE changed AND is_obsolete' and read the changelog at https://github.com/ClickHouse/ClickHouse/blob/master/CHANGELOG.md"; common_warnings.emplace_back(res); } From 47132532b82b6d84748ad95e50343c4c8d320a8b Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Fri, 10 Nov 2023 01:34:03 +0100 Subject: [PATCH 2/2] Fix test --- tests/queries/0_stateless/01945_system_warnings.reference | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/queries/0_stateless/01945_system_warnings.reference b/tests/queries/0_stateless/01945_system_warnings.reference index cfec2f63816..f77cdd275c9 100644 --- a/tests/queries/0_stateless/01945_system_warnings.reference +++ b/tests/queries/0_stateless/01945_system_warnings.reference @@ -1,5 +1,5 @@ Server was built in debug mode. It will work slowly. 0 -Obsolete setting [\'multiple_joins_rewriter_version\'] is changed. Please check \'select * from system.settings where changed and is_obsolete\' and read the changelog. +Obsolete setting [\'multiple_joins_rewriter_version\'] is changed. Please check \'SELECT * FROM system.settings WHERE changed AND is_obsolete\' and read the changelog at https://github.com/ClickHouse/ClickHouse/blob/master/CHANGELOG.md 1 1