thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11936 from ClickHouse/fix_11918

Browse Source 
Fix query parameter visitor
This commit is contained in:
alexey-milovidov 2020-06-26 00:54:37 +03:00 committed by GitHub
commit 6a45f3e960
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Interpreters/ReplaceQueryParameterVisitor.cpp
View File

@ -26,13 +26,17 @@ namespace ErrorCodes
void ReplaceQueryParameterVisitor::visit(ASTPtr & ast)
{
for (auto & child : ast->children)
{
if (child->as<ASTQueryParameter>())
visitQueryParameter(child);
if (ast->as<ASTQueryParameter>())
visitQueryParameter(ast);
else
visitChildren(ast);
}
void ReplaceQueryParameterVisitor::visitChildren(ASTPtr & ast)
{
for (auto & child : ast->children)
visit(child);
}
}
const String & ReplaceQueryParameterVisitor::getParamValue(const String & name)

1
src/Interpreters/ReplaceQueryParameterVisitor.h
View File

@ -22,6 +22,7 @@ private:
const NameToNameMap & query_parameters;
const String & getParamValue(const String & name);
void visitQueryParameter(ASTPtr & ast);
void visitChildren(ASTPtr & ast);
};
}

1
tests/queries/0_stateless/01015_insert_values_parametrized.reference
View File

@ -3,3 +3,4 @@
2 testparam [0.3]
3 paramparam []
4 evaluateparam [0.2]
5 param [0.2,0.3]

3
tests/queries/0_stateless/01015_insert_values_parametrized.sh
View File

@ -15,6 +15,9 @@ $CLICKHOUSE_CLIENT --input_format_values_deduce_templates_of_expressions=1 --inp
$CLICKHOUSE_CLIENT --input_format_values_deduce_templates_of_expressions=0 --input_format_values_interpret_expressions=1 --param_p_n="-1" --param_p_s="param" --param_p_a="[0.2,0.3]" --query="INSERT INTO insert_values_parametrized VALUES \
(5 + {p_n:Int8}, lower(concat('Evaluate', {p_s:String})), arrayIntersect([0, 0.2, 0.6], {p_a:Array(Nullable(Float32))}))"
$CLICKHOUSE_CLIENT --param_p_n="5" --param_p_s="param" --param_p_a="[0.2,0.3]" --query="INSERT INTO insert_values_parametrized VALUES \
({p_n:Int8}, {p_s:String}, {p_a:Array(Nullable(Float32))})"
$CLICKHOUSE_CLIENT --query="SELECT * FROM insert_values_parametrized ORDER BY n";
$CLICKHOUSE_CLIENT --query="DROP TABLE insert_values_parametrized";