Move protocol macros into separate header

Defines.h is a very common header, so lots of modules will be recompiled
on changes.
Move macros for protocol into separate header, this should significantly
decreases number of units to compile on it's changes.

src/Core/Defines.h

@@ -51,52 +51,6 @@
 /// replica error max cap, this is to prevent replica from accumulating too many errors and taking to long to recover.
 #define DBMS_CONNECTION_POOL_WITH_FAILOVER_MAX_ERROR_COUNT 1000
 
-#define DBMS_MIN_REVISION_WITH_CLIENT_INFO 54032
-#define DBMS_MIN_REVISION_WITH_SERVER_TIMEZONE 54058
-#define DBMS_MIN_REVISION_WITH_QUOTA_KEY_IN_CLIENT_INFO 54060
-#define DBMS_MIN_REVISION_WITH_TABLES_STATUS 54226
-#define DBMS_MIN_REVISION_WITH_TIME_ZONE_PARAMETER_IN_DATETIME_DATA_TYPE 54337
-#define DBMS_MIN_REVISION_WITH_SERVER_DISPLAY_NAME 54372
-#define DBMS_MIN_REVISION_WITH_VERSION_PATCH 54401
-#define DBMS_MIN_REVISION_WITH_SERVER_LOGS 54406
-#define DBMS_MIN_REVISION_WITH_CLIENT_SUPPORT_EMBEDDED_DATA 54415
-/// Minimum revision with exactly the same set of aggregation methods and rules to select them.
-/// Two-level (bucketed) aggregation is incompatible if servers are inconsistent in these rules
-/// (keys will be placed in different buckets and result will not be fully aggregated).
-#define DBMS_MIN_REVISION_WITH_CURRENT_AGGREGATION_VARIANT_SELECTION_METHOD 54431
-#define DBMS_MIN_REVISION_WITH_COLUMN_DEFAULTS_METADATA 54410
-
-#define DBMS_MIN_REVISION_WITH_LOW_CARDINALITY_TYPE 54405
-#define DBMS_MIN_REVISION_WITH_CLIENT_WRITE_INFO 54420
-
-/// Minimum revision supporting SettingsBinaryFormat::STRINGS.
-#define DBMS_MIN_REVISION_WITH_SETTINGS_SERIALIZED_AS_STRINGS 54429
-#define DBMS_MIN_REVISION_WITH_SCALARS 54429
-
-/// Minimum revision supporting OpenTelemetry
-#define DBMS_MIN_REVISION_WITH_OPENTELEMETRY 54442
-
-
-#define DBMS_CLUSTER_PROCESSING_PROTOCOL_VERSION 1
-
-/// Minimum revision supporting interserver secret.
-#define DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET 54441
-
-#define DBMS_MIN_REVISION_WITH_X_FORWARDED_FOR_IN_CLIENT_INFO 54443
-#define DBMS_MIN_REVISION_WITH_REFERER_IN_CLIENT_INFO 54447
-
-#define DBMS_MIN_PROTOCOL_VERSION_WITH_DISTRIBUTED_DEPTH 54448
-
-/// Version of ClickHouse TCP protocol.
-///
-/// Should be incremented manually on protocol changes.
-///
-/// NOTE: DBMS_TCP_PROTOCOL_VERSION has nothing common with VERSION_REVISION,
-/// later is just a number for server version (one number instead of commit SHA)
-/// for simplicity (sometimes it may be more convenient in some use cases).
-#define DBMS_TCP_PROTOCOL_VERSION 54449
-
-#define DBMS_MIN_PROTOCOL_VERSION_WITH_INITIAL_QUERY_START_TIME 54449
 /// The boundary on which the blocks for asynchronous file operations should be aligned.
 #define DEFAULT_AIO_FILE_BLOCK_SIZE 4096
 

src/Core/Protocol.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <base/types.h>
+#include <Core/ProtocolDefines.h>
 
 
 namespace DB

src/Core/ProtocolDefines.h

@@ -0,0 +1,48 @@
+#pragma once
+
+#define DBMS_MIN_REVISION_WITH_CLIENT_INFO 54032
+#define DBMS_MIN_REVISION_WITH_SERVER_TIMEZONE 54058
+#define DBMS_MIN_REVISION_WITH_QUOTA_KEY_IN_CLIENT_INFO 54060
+#define DBMS_MIN_REVISION_WITH_TABLES_STATUS 54226
+#define DBMS_MIN_REVISION_WITH_TIME_ZONE_PARAMETER_IN_DATETIME_DATA_TYPE 54337
+#define DBMS_MIN_REVISION_WITH_SERVER_DISPLAY_NAME 54372
+#define DBMS_MIN_REVISION_WITH_VERSION_PATCH 54401
+#define DBMS_MIN_REVISION_WITH_SERVER_LOGS 54406
+#define DBMS_MIN_REVISION_WITH_CLIENT_SUPPORT_EMBEDDED_DATA 54415
+/// Minimum revision with exactly the same set of aggregation methods and rules to select them.
+/// Two-level (bucketed) aggregation is incompatible if servers are inconsistent in these rules
+/// (keys will be placed in different buckets and result will not be fully aggregated).
+#define DBMS_MIN_REVISION_WITH_CURRENT_AGGREGATION_VARIANT_SELECTION_METHOD 54431
+#define DBMS_MIN_REVISION_WITH_COLUMN_DEFAULTS_METADATA 54410
+
+#define DBMS_MIN_REVISION_WITH_LOW_CARDINALITY_TYPE 54405
+#define DBMS_MIN_REVISION_WITH_CLIENT_WRITE_INFO 54420
+
+/// Minimum revision supporting SettingsBinaryFormat::STRINGS.
+#define DBMS_MIN_REVISION_WITH_SETTINGS_SERIALIZED_AS_STRINGS 54429
+#define DBMS_MIN_REVISION_WITH_SCALARS 54429
+
+/// Minimum revision supporting OpenTelemetry
+#define DBMS_MIN_REVISION_WITH_OPENTELEMETRY 54442
+
+
+#define DBMS_CLUSTER_PROCESSING_PROTOCOL_VERSION 1
+
+/// Minimum revision supporting interserver secret.
+#define DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET 54441
+
+#define DBMS_MIN_REVISION_WITH_X_FORWARDED_FOR_IN_CLIENT_INFO 54443
+#define DBMS_MIN_REVISION_WITH_REFERER_IN_CLIENT_INFO 54447
+
+#define DBMS_MIN_PROTOCOL_VERSION_WITH_DISTRIBUTED_DEPTH 54448
+
+/// Version of ClickHouse TCP protocol.
+///
+/// Should be incremented manually on protocol changes.
+///
+/// NOTE: DBMS_TCP_PROTOCOL_VERSION has nothing common with VERSION_REVISION,
+/// later is just a number for server version (one number instead of commit SHA)
+/// for simplicity (sometimes it may be more convenient in some use cases).
+#define DBMS_TCP_PROTOCOL_VERSION 54449
+
+#define DBMS_MIN_PROTOCOL_VERSION_WITH_INITIAL_QUERY_START_TIME 54449

src/DataStreams/NativeBlockOutputStream.cpp

@@ -1,4 +1,4 @@
-#include <Core/Defines.h>
+#include <Core/ProtocolDefines.h>
 #include <Core/Block.h>
 
 #include <IO/WriteHelpers.h>

src/DataStreams/TemporaryFileStream.cpp

@@ -7,6 +7,7 @@
 #include <Processors/ISource.h>
 #include <Compression/CompressedWriteBuffer.h>
 #include <IO/WriteBufferFromFile.h>
+#include <Core/ProtocolDefines.h>
 
 
 namespace DB

src/IO/Progress.cpp

@@ -4,6 +4,7 @@
 #include <IO/WriteBuffer.h>
 #include <IO/ReadHelpers.h>
 #include <IO/WriteHelpers.h>
+#include <Core/ProtocolDefines.h>
 
 
 namespace DB

src/Interpreters/Aggregator.cpp

@@ -24,6 +24,7 @@
 #include <IO/Operators.h>
 #include <Interpreters/JIT/compileFunction.h>
 #include <Interpreters/JIT/CompiledExpressionCache.h>
+#include <Core/ProtocolDefines.h>
 
 
 namespace ProfileEvents

src/Interpreters/ClientInfo.cpp

@@ -3,7 +3,7 @@
 #include <IO/WriteBuffer.h>
 #include <IO/ReadHelpers.h>
 #include <IO/WriteHelpers.h>
-#include <Core/Defines.h>
+#include <Core/ProtocolDefines.h>
 #include <base/getFQDNOrHostName.h>
 #include <unistd.h>
 

src/Interpreters/TablesStatus.cpp

@@ -3,6 +3,7 @@
 #include <IO/WriteBuffer.h>
 #include <IO/ReadHelpers.h>
 #include <IO/WriteHelpers.h>
+#include <Core/ProtocolDefines.h>
 
 namespace DB
 {

src/Processors/Transforms/AggregatingTransform.cpp

@@ -5,6 +5,7 @@
 #include <Processors/Pipe.h>
 #include <Processors/Transforms/MergingAggregatedMemoryEfficientTransform.h>
 #include <DataStreams/materializeBlock.h>
+#include <Core/ProtocolDefines.h>
 
 namespace ProfileEvents
 {