thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 20:42:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adjusted comments in the .h

Browse Source
This commit is contained in:
akazz 2019-07-23 13:34:56 +03:00
parent 58d83e44ed
commit 6aae1ad391
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dbms/src/Functions/FunctionsLogical.h
View File

@ -18,7 +18,7 @@
#endif #endif
/// TODO: Is it okay to reference this URL???
/** Logical functions AND, OR, XOR and NOT support three-valued (or ternary) logic /** Logical functions AND, OR, XOR and NOT support three-valued (or ternary) logic
* https://en.wikibooks.org/wiki/Structured_Query_Language/NULLs_and_the_Three_Valued_Logic * https://en.wikibooks.org/wiki/Structured_Query_Language/NULLs_and_the_Three_Valued_Logic
* *
@ -83,10 +83,11 @@ struct XorImpl
static inline constexpr bool isSaturable() { return false; } static inline constexpr bool isSaturable() { return false; }
static inline constexpr bool isSaturatedValue(bool) { return false; } static inline constexpr bool isSaturatedValue(bool) { return false; }
/// TODO: (Is this legit???) Considering that CH uses UInt8 for representation of boolean values this function /** Considering that CH uses UInt8 for representation of boolean values this function
/// returns 255 as "true" but the current implementation of logical functions * returns 255 as "true" but the current implementation of logical functions suggests that
/// suggests that any nonzero value is "true" as well. Also the current code provides no guarantee * any nonzero value is "true" as well. Also the current code provides no guarantee
/// for "true" to be represented with the value of 1. * for "true" to be represented with the value of 1.
*/
static inline constexpr ResultType apply(UInt8 a, UInt8 b) { return (a != b) ? Ternary::True : Ternary::False; } static inline constexpr ResultType apply(UInt8 a, UInt8 b) { return (a != b) ? Ternary::True : Ternary::False; }
static inline constexpr bool specialImplementationForNulls() { return false; } static inline constexpr bool specialImplementationForNulls() { return false; }