thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 03:22:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Print original query for AST formatting check on CI

Browse Source 
It may be tricky to understand the root cause of the AST formatting
issue in case of syntax error, so add one knob to control this -
debug_ast_formatting_print_original_query.

And CI contains core dumps anyway, so let's enable for CI.

P.S. There was concern from @al13n321 that printing original query even
in debug build is not a good idea [1], hence a knob for this.

  [1]: https://github.com/ClickHouse/ClickHouse/pull/63357/files#r1674809348

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
Azat Khuzhin 2024-08-04 22:50:46 +02:00
parent ce58549592
commit 6b1e184e12
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Interpreters/executeQuery.cpp
View File

@ -796,10 +796,9 @@ static std::tuple<ASTPtr, BlockIO> executeQueryImpl(
catch (const Exception & e) catch (const Exception & e)
{ {
if (e.code() == ErrorCodes::SYNTAX_ERROR) if (e.code() == ErrorCodes::SYNTAX_ERROR)
/// Don't print the original query text because it may contain sensitive data.
throw Exception(ErrorCodes::LOGICAL_ERROR, throw Exception(ErrorCodes::LOGICAL_ERROR,
"Inconsistent AST formatting: the query:\n{}\ncannot parse.", "Inconsistent AST formatting: the query:\n{}\ncannot parse query back from {}",
formatted1); formatted1, std::string_view(begin, end-begin));
else else
throw; throw;
} }