thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 03:22:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix null insertion into dynamic column

Browse Source
This commit is contained in:
Kruglov Pavel 2024-07-09 14:01:28 +02:00 committed by GitHub
parent 9153e65456
commit 6baa52d101
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Formats/JSONExtractTree.cpp
View File

@ -1265,9 +1265,16 @@ public:
bool insertResultToColumn(IColumn & column, const typename JSONParser::Element & element, const JSONExtractInsertSettings & insert_settings, const FormatSettings & format_settings, String & error) const override
{
auto & column_dynamic = assert_cast<ColumnDynamic &>(column);
/// First, check if element is NULL.
if (element.isNull())
{
column_dynamic.insertDefault();
return true;
}
auto & variant_column = column_dynamic.getVariantColumn();
auto variant_info = column_dynamic.getVariantInfo();
/// First, infer ClickHouse type for this element and add it as a new variant.
/// Second, infer ClickHouse type for this element and add it as a new variant.
auto element_type = elementToDataType(element, format_settings);
if (column_dynamic.addNewVariant(element_type))
{