Fix flaky test 01459_manual_write_to_replicas_quorum_detach_attach and several typos

This commit is contained in:
alesapin 2023-01-03 16:27:51 +01:00
parent 16fca48f5b
commit 6c8dbcc040
7 changed files with 13 additions and 8 deletions

View File

@ -1203,7 +1203,7 @@ auto DDperformanceTestSequence()
+ generateSeq<ValueType>(G(SameValueGenerator(42)), 0, times); // best + generateSeq<ValueType>(G(SameValueGenerator(42)), 0, times); // best
} }
// prime numbers in ascending order with some random repitions hit all the cases of Gorilla. // prime numbers in ascending order with some random repetitions hit all the cases of Gorilla.
auto PrimesWithMultiplierGenerator = [](int multiplier = 1) auto PrimesWithMultiplierGenerator = [](int multiplier = 1)
{ {
return [multiplier](auto i) return [multiplier](auto i)

View File

@ -205,7 +205,7 @@ public:
const String & expression_return_name_) const String & expression_return_name_)
: expression_actions(std::move(expression_actions_)) : expression_actions(std::move(expression_actions_))
{ {
/// Check that expression does not contain unusual actions that will break columnss structure. /// Check that expression does not contain unusual actions that will break columns structure.
for (const auto & action : expression_actions->getActions()) for (const auto & action : expression_actions->getActions())
if (action.node->type == ActionsDAG::ActionType::ARRAY_JOIN) if (action.node->type == ActionsDAG::ActionType::ARRAY_JOIN)
throw Exception("Expression with arrayJoin or other unusual action cannot be captured", ErrorCodes::BAD_ARGUMENTS); throw Exception("Expression with arrayJoin or other unusual action cannot be captured", ErrorCodes::BAD_ARGUMENTS);

View File

@ -210,7 +210,7 @@ public:
throw Exception("There are no available implementations for function " "TODO(dakovalkov): add name", throw Exception("There are no available implementations for function " "TODO(dakovalkov): add name",
ErrorCodes::NO_SUITABLE_FUNCTION_IMPLEMENTATION); ErrorCodes::NO_SUITABLE_FUNCTION_IMPLEMENTATION);
/// Statistics shouldn't rely on small columnss. /// Statistics shouldn't rely on small columns.
bool considerable = (input_rows_count > 1000); bool considerable = (input_rows_count > 1000);
ColumnPtr res; ColumnPtr res;

View File

@ -10,7 +10,7 @@ namespace DB
namespace namespace
{ {
/** Incremental number of row within all columnss passed to this function. */ /** Incremental number of row within all columns passed to this function. */
class FunctionRowNumberInAllBlocks : public IFunction class FunctionRowNumberInAllBlocks : public IFunction
{ {
private: private:

View File

@ -27,7 +27,7 @@ namespace
* Takes state of aggregate function (example runningAccumulate(uniqState(UserID))), * Takes state of aggregate function (example runningAccumulate(uniqState(UserID))),
* and for each row of columns, return result of aggregate function on merge of states of all previous rows and current row. * and for each row of columns, return result of aggregate function on merge of states of all previous rows and current row.
* *
* So, result of function depends on partition of data to columnss and on order of data in columns. * So, result of function depends on partition of data to columns and on order of data in columns.
*/ */
class FunctionRunningAccumulate : public IFunction class FunctionRunningAccumulate : public IFunction
{ {

View File

@ -38,13 +38,13 @@ struct FunctionRunningDifferenceName<false>
}; };
/** Calculate difference of consecutive values in columns. /** Calculate difference of consecutive values in columns.
* So, result of function depends on partition of data to columnss and on order of data in columns. * So, result of function depends on partition of data to columns and on order of data in columns.
*/ */
template <bool is_first_line_zero> template <bool is_first_line_zero>
class FunctionRunningDifferenceImpl : public IFunction class FunctionRunningDifferenceImpl : public IFunction
{ {
private: private:
/// It is possible to track value from previous columns, to calculate continuously across all columnss. Not implemented. /// It is possible to track value from previous columns, to calculate continuously across all columns. Not implemented.
template <typename Src, typename Dst> template <typename Src, typename Dst>
static NO_SANITIZE_UNDEFINED void process(const PaddedPODArray<Src> & src, PaddedPODArray<Dst> & dst, const NullMap * null_map) static NO_SANITIZE_UNDEFINED void process(const PaddedPODArray<Src> & src, PaddedPODArray<Dst> & dst, const NullMap * null_map)

View File

@ -42,5 +42,10 @@ for i in $(seq 1 $NUM_REPLICAS); do
done done
for i in $(seq 1 $NUM_REPLICAS); do for i in $(seq 1 $NUM_REPLICAS); do
$CLICKHOUSE_CLIENT -q "DROP TABLE IF EXISTS r$i SYNC;" # We filter out 'Removing temporary directory' on table DROP because in this test
# we constantly DETACH and ATTACH tables. So some replica can start fetching some part
# and other replica can be DETACHed during fetch. We will get unfinished tmp directory
# which should be removed in background, but it's async operation so the tmp directory can
# left on disk until table DROP.
$CLICKHOUSE_CLIENT -q "DROP TABLE IF EXISTS r$i SYNC;" 2>&1 | grep -v 'Removing temporary directory' ||:
done done