From 22954cc12393f8a0ad9c345eec094cacd8d01fa8 Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@yandex-team.ru>
Date: Wed, 4 Nov 2020 19:48:36 +0300
Subject: [PATCH 1/2] Fix UBSan report when trying to convert infinite floating
 point number to integer

---
 src/Common/FieldVisitors.h                                   | 5 +++++
 .../01557_field_infinite_convert_to_number.reference         | 0
 .../0_stateless/01557_field_infinite_convert_to_number.sql   | 1 +
 3 files changed, 6 insertions(+)
 create mode 100644 tests/queries/0_stateless/01557_field_infinite_convert_to_number.reference
 create mode 100644 tests/queries/0_stateless/01557_field_infinite_convert_to_number.sql

diff --git a/src/Common/FieldVisitors.h b/src/Common/FieldVisitors.h
index 4fcb3091833..421423131a2 100644
--- a/src/Common/FieldVisitors.h
+++ b/src/Common/FieldVisitors.h
@@ -3,6 +3,7 @@
 #include <Core/DecimalFunctions.h>
 #include <Core/Field.h>
 #include <common/demangle.h>
+#include <Common/NaNUtils.h>
 
 
 class SipHash;
@@ -142,6 +143,10 @@ public:
 
     T operator() (const Float64 & x) const
     {
+        if constexpr (!std::is_floating_point_v<T>)
+            if (!isFinite(x))
+                throw Exception("Cannot convert infinite value to integer type", ErrorCodes::CANNOT_CONVERT_TYPE);
+
         if constexpr (std::is_same_v<Decimal256, T>)
             return Int256(x);
         else
diff --git a/tests/queries/0_stateless/01557_field_infinite_convert_to_number.reference b/tests/queries/0_stateless/01557_field_infinite_convert_to_number.reference
new file mode 100644
index 00000000000..e69de29bb2d
diff --git a/tests/queries/0_stateless/01557_field_infinite_convert_to_number.sql b/tests/queries/0_stateless/01557_field_infinite_convert_to_number.sql
new file mode 100644
index 00000000000..edc4d5cbc91
--- /dev/null
+++ b/tests/queries/0_stateless/01557_field_infinite_convert_to_number.sql
@@ -0,0 +1 @@
+SET max_threads = nan; -- { serverError 70 }

From 65aa226bcd09fd9bccb1c9cb91d2ac183c8ed9c4 Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@yandex-team.ru>
Date: Thu, 5 Nov 2020 12:26:51 +0300
Subject: [PATCH 2/2] Fix test

---
 src/Common/FieldVisitors.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/Common/FieldVisitors.h b/src/Common/FieldVisitors.h
index 421423131a2..79d5af88904 100644
--- a/src/Common/FieldVisitors.h
+++ b/src/Common/FieldVisitors.h
@@ -144,8 +144,17 @@ public:
     T operator() (const Float64 & x) const
     {
         if constexpr (!std::is_floating_point_v<T>)
+        {
             if (!isFinite(x))
+            {
+                /// When converting to bool it's ok (non-zero converts to true, NaN including).
+                if (std::is_same_v<T, bool>)
+                    return true;
+
+                /// Conversion of infinite values to integer is undefined.
                 throw Exception("Cannot convert infinite value to integer type", ErrorCodes::CANNOT_CONVERT_TYPE);
+            }
+        }
 
         if constexpr (std::is_same_v<Decimal256, T>)
             return Int256(x);