thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-24 10:40:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

OPTIMIZE(1)

Browse Source
This commit is contained in:
Alexander Tokmakov 2019-05-01 23:22:09 +03:00 committed by Alexander Tokmakov
parent 66ae943899
commit 6e4efb94f0
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dbms/src/Formats/RowInputStreamWithDiagnosticInfo.cpp
View File

@ -83,7 +83,13 @@ String DB::RowInputStreamWithDiagnosticInfo::getDiagnosticInfo()
return out.str();
}
bool RowInputStreamWithDiagnosticInfo::deserializeFieldAndPrintDiagnosticInfo(const String & col_name, const DataTypePtr & type,
/** gcc-7 may generate wrong code with optimization level greater than 1.
* See tests: dbms/src/IO/tests/write_int.cpp
* and dbms/tests/queries/0_stateless/00898_parsing_bad_diagnostic_message.sh
* This is compiler bug. The bug does not present in gcc-8 and clang-8.
* Nevertheless, we don't need high optimization of this function.
*/
bool OPTIMIZE(1) RowInputStreamWithDiagnosticInfo::deserializeFieldAndPrintDiagnosticInfo(const String & col_name, const DataTypePtr & type,
IColumn & column,
WriteBuffer & out,
size_t input_position)