diff --git a/src/Core/AccurateComparison.h b/src/Core/AccurateComparison.h index 23d0dce6565..085c535a214 100644 --- a/src/Core/AccurateComparison.h +++ b/src/Core/AccurateComparison.h @@ -274,12 +274,14 @@ inline bool greaterOp(DB::UInt64 u, DB::Float32 f) template <> inline bool greaterOp(DB::Float64 f, DB::UInt128 u) { + /// TODO: This is wrong. return u.low == 0 && greaterOp(f, u.high); } template <> inline bool greaterOp(DB::UInt128 u, DB::Float64 f) { + /// TODO: This is wrong. return u.low != 0 || greaterOp(u.high, f); } @@ -360,6 +362,7 @@ inline bool NO_SANITIZE_UNDEFINED equalsOp(DB::Int64 u, template <> inline bool NO_SANITIZE_UNDEFINED equalsOp(DB::UInt128 u, DB::Float64 f) { + /// TODO: This is wrong. return u.low == 0 && equalsOp(static_cast(u.high), f); }