From 6ebe4e7dbbf43371505e3620601cfe326b5b29df Mon Sep 17 00:00:00 2001
From: Azat Khuzhin <a3at.mail@gmail.com>
Date: Sat, 27 Mar 2021 07:20:16 +0300
Subject: [PATCH] Do not silently catch errors for writing to S3

---
 src/IO/WriteBufferFromS3.cpp | 12 ------------
 src/IO/WriteBufferFromS3.h   |  2 --
 2 files changed, 14 deletions(-)

diff --git a/src/IO/WriteBufferFromS3.cpp b/src/IO/WriteBufferFromS3.cpp
index a63e00efce4..1ae1b56933d 100644
--- a/src/IO/WriteBufferFromS3.cpp
+++ b/src/IO/WriteBufferFromS3.cpp
@@ -112,18 +112,6 @@ void WriteBufferFromS3::finalizeImpl()
     finalized = true;
 }
 
-WriteBufferFromS3::~WriteBufferFromS3()
-{
-    try
-    {
-        finalizeImpl();
-    }
-    catch (...)
-    {
-        tryLogCurrentException(log);
-    }
-}
-
 void WriteBufferFromS3::createMultipartUpload()
 {
     Aws::S3::Model::CreateMultipartUploadRequest req;
diff --git a/src/IO/WriteBufferFromS3.h b/src/IO/WriteBufferFromS3.h
index 7a77949072b..2e61fef61c8 100644
--- a/src/IO/WriteBufferFromS3.h
+++ b/src/IO/WriteBufferFromS3.h
@@ -64,8 +64,6 @@ public:
     /// Receives response from the server after sending all data.
     void finalize() override;
 
-    ~WriteBufferFromS3() override;
-
 private:
     bool finalized = false;