thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-01 12:01:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #66776 from ClickHouse/disable_harmful_setting_from_randomizaiton

Browse Source 
Turn off randomization of harmful setting
This commit is contained in:
alesapin 2024-07-20 09:43:47 +00:00 committed by GitHub
commit 6eec3c2c99
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/clickhouse-test
View File

@ -821,7 +821,10 @@ class SettingsRandomizer:
get_localzone(), get_localzone(),
] ]
), ),
"prefer_warmed_unmerged_parts_seconds": lambda: random.randint(0, 10), # This setting affect part names and their content which can be read from tables in tests.
# We have a lot of tests which relies on part names, so it's very unsafe to enable randomization
# of this setting
# "prefer_warmed_unmerged_parts_seconds": lambda: random.randint(0, 10),
"use_page_cache_for_disks_without_file_cache": lambda: random.random() < 0.7, "use_page_cache_for_disks_without_file_cache": lambda: random.random() < 0.7,
"page_cache_inject_eviction": lambda: random.random() < 0.5, "page_cache_inject_eviction": lambda: random.random() < 0.5,
"merge_tree_read_split_ranges_into_intersecting_and_non_intersecting_injection_probability": lambda: round( "merge_tree_read_split_ranges_into_intersecting_and_non_intersecting_injection_probability": lambda: round(

8
tests/queries/0_stateless/replication.lib
View File

@ -79,7 +79,9 @@ function check_replication_consistency()
fi fi
# Touch all data to check that it's readable (and trigger PartCheckThread if needed) # Touch all data to check that it's readable (and trigger PartCheckThread if needed)
while ! $CLICKHOUSE_CLIENT -q "SELECT * FROM merge(currentDatabase(), '$table_name_prefix') FORMAT Null" 2>/dev/null; do # it's important to disable prefer warmed unmerged parts because
# otherwise it can read non-syncrhonized state of replicas
while ! $CLICKHOUSE_CLIENT --prefer_warmed_unmerged_parts_seconds=0 -q "SELECT * FROM merge(currentDatabase(), '$table_name_prefix') FORMAT Null" 2>/dev/null; do
sleep 1; sleep 1;
num_tries=$((num_tries+1)) num_tries=$((num_tries+1))
if [ $num_tries -eq 250 ]; then if [ $num_tries -eq 250 ]; then
@ -102,7 +104,9 @@ function check_replication_consistency()
try_sync_replicas "$table_name_prefix" "$time_left" || exit 1 try_sync_replicas "$table_name_prefix" "$time_left" || exit 1
res=$($CLICKHOUSE_CLIENT -q \ # it's important to disable prefer warmed unmerged parts because
# otherwise it can read non-syncrhonized state of replicas
res=$($CLICKHOUSE_CLIENT --prefer_warmed_unmerged_parts_seconds=0 -q \
"SELECT "SELECT
if((countDistinct(data) as c) == 0, 1, c) if((countDistinct(data) as c) == 0, 1, c)
FROM FROM